Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBE should support llvm.stacksave/stackrestore #1400

Closed
lattner opened this issue Dec 1, 2006 · 8 comments
Closed

CBE should support llvm.stacksave/stackrestore #1400

lattner opened this issue Dec 1, 2006 · 8 comments
Labels
bugzilla Issues migrated from bugzilla enhancement Improving things as opposed to bug fixing, e.g. new or missing feature

Comments

@lattner
Copy link
Collaborator

lattner commented Dec 1, 2006

Bugzilla Link 1028
Resolution FIXED
Resolved on Feb 22, 2010 12:53
Version trunk
OS All

Extended Description

The CBE should translate llvm.stacksave/stackrestore into calls to GCC's __builtin_stack_save/
__builtin_stack_restore functions. The only tricky part of this is figuring out which versions of GCC have
these builtins (if we care).

This would get 176.gcc working with the CBE, which would be very useful when bugpointing.

-Chris
@llvmbot
Copy link
Collaborator

llvmbot commented Jan 17, 2007

Possible patch here:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20070115/042825.html

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 17, 2007

Gordon,

The patch came through completely garbled. Could you please attach it to this PR
using the "Create a New Attachment" link and provide it in plain text, not gzipped.

Thanks,

Reid.

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 18, 2007

PR1028.patch

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 18, 2007

2007-01-16-StackSaveRestore.ll

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 18, 2007

Sure.

patch include/llvm/Intrinsics.td < llvm/llvm-bugzilla-archive#1028 .patch
mv 2007-01-16-StackSaveRestore.ll test/CodeGen/CBackend

The original was a .tar.gz, which might account for the corruption.

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 18, 2007

Hi, Gordon.

I'm just testing your patches now. If it all works out, I'll commit shortly.

FYI, the script in utils/mkpatch might help with future patch generation. It
puts it in a form and order that we like to see.

Thanks,

Reid.

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 18, 2007

Nice patch, Gordon.

This fixes 176.gcc/CBE. Its been a long outstanding issue.

Well done.

Reid.

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 26, 2007

*** Bug llvm/llvm-bugzilla-archive#1273 has been marked as a duplicate of this bug. ***

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
JacobMarksLANL pushed a commit to JacobMarksLANL/kitsune that referenced this issue Feb 9, 2022
@clementval
[flang] Sync TargetRewrite.cpp from main to fir-dev (llvm#1400)
9e91e04
@Endilll Endilll added enhancement Improving things as opposed to bug fixing, e.g. new or missing feature and removed missing-feature labels Aug 15, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla enhancement Improving things as opposed to bug fixing, e.g. new or missing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Endilll @lattner @llvmbot