Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-upgrade deletes Type instances !! #1523

Closed
lattner opened this issue Jan 31, 2007 · 5 comments
Closed

llvm-upgrade deletes Type instances !! #1523

lattner opened this issue Jan 31, 2007 · 5 comments
Labels
bugzilla Issues migrated from bugzilla compile-fail Use [accepts-invalid] and [rejects-valid] instead llvm-tools All llvm tools that do not have corresponding tag

Comments

@lattner
Copy link
Collaborator

lattner commented Jan 31, 2007

Bugzilla Link 1151
Resolution FIXED
Resolved on Feb 22, 2010 12:53
Version trunk
OS All

Extended Description

test/Assembler/2007-01-22-UpgradeTypeMapInvalidMemory.ll is failing on mainline
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 2, 2007

I can't reproduce this. Is it still failing for you?

@lattner
Copy link
Collaborator Author

lattner commented Feb 4, 2007

yep, I get:

llvm-upgrade < 2007-01-22-UpgradeTypeMapInvalidMemory.ll -o /dev/null -f
Type.cpp:398: failed assertion `(Params[i]->isFirstClassType() || isa(Params[i])) &&
"Function arguments must be value types!"'

@llvmbot
Copy link
Collaborator

llvmbot commented Feb 4, 2007

Fixed with this patch:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20070129/043844.html

@llvmbot
Copy link
Collaborator

llvmbot commented Feb 4, 2007

Chris,

Please verify that this works for you now. I have no we of verifying if the
patch actually fixed the symptom you're seeing.

Reid.

@lattner
Copy link
Collaborator Author

lattner commented Feb 4, 2007

works for me now, thanks Reid!

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
JacobMarksLANL pushed a commit to JacobMarksLANL/kitsune that referenced this issue Mar 11, 2022
@schweitzpgi
Change the symbol map to map ultimate symbols rather than whatever (l…
1a3ec76 
…lvm#1523)

symbol the client supplies.  Specifically, this changes how host and
use associated placeholder symbols are inserted and fetched from the
symbol table.

This should help eliminate the class of "symbol not found" assertions
such as when the front-end symbol has multiple identities for the same
variable.

The change mostly impacts OpenMP lowering, which deals with associated
symbols.

NFC: Remove commented out code. (No longer needed.)

React to review comments.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla compile-fail Use [accepts-invalid] and [rejects-valid] instead llvm-tools All llvm tools that do not have corresponding tag
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lattner @llvmbot