-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another InstCombine issue #1620
Comments
I think that this is trying to simplify (x sdiv 12) != -6 |
Here's a reduced testcase: instcombine compiles it to: define i1 @test(i32 %tmp6) { which is wrong for an input of -70. -Chris |
This appears to be fallout from the signless types change. The problem is AddWithOverflow in Instcombine. It is not calculating overflow correctly if the operands Reid, plz investigate. -Chris |
Mine. |
Making the AddWithOverflow change doesn't fix the problem. |
Turns out there were two bugs. The AddWithOverflow needed to be APIntified and This patch was applied: |
lldbutil: add a retry mechanism for the ios simulator
Extended Description
Consider the attached bytecode. This is just -O0 compiled bytecode from gcc
testsuite.
Running "opt -instcombine" will lead to "eq" comparison turn to "slt", which is
definitely wrong.
The text was updated successfully, but these errors were encountered: