-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instcombine broken after APIntification #1643
Comments
Mine. |
This patch: fixes the "simple" test case that Chris narrowed it down to: InstCombine now generates: Unfortunately, this didn't fix SingleSource/Regression/C/2003-05-21-UnionBitFields.c |
Unfortunately, things are still broken: Qt crashes, llvm-gcc bootstrap too. |
.ll before instcombine |
I've attached testcase from llvm-gcc bootstrap. Actually, it's Fortunately, diff between .ll's is not so big. I've found only one suspicious
It seems, that presence of "add" is not taken into account... |
It looks like 2003-09-18-BitFieldTest.c is failing because Maybe it is related. |
FWIW, the ppc llvm-gcc bootstrap is miscompiling itself, and the following new programs fail: New Test Failures: -Chris |
With this patch: bugpoint has reduced an -instcombine test case with this result:
|
This was another bad shift mask. The bugpoint reduced test case is here: Fix patch is here: |
Anton, This has passed llvm/test, llvm-test, and a bootstrap build of llvm-gcc. I'm calling it done. If you find more bugs in instcombine (e.g. Qt, SeaMonkey), Thanks, Reid. |
Seems ok to me. Thanks. |
Extended Description
instcombine is broken now.
This leads to big miscompilations here and there.
The smallest testcase is:
Regression/C/2003-05-21-UnionBitfields.c
The text was updated successfully, but these errors were encountered: