New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] const arrays are not mangled properly #13554
Comments
assigned to @pcc |
I haven't been able to fix this so far and maybe won't be doing that for some time, so feel free to take over. |
Thanks for the heads up. I'm also not sure when I'll be able to look into this, so if someone else wants to do it, feel free :) |
Taking this PR. |
One more broken thing: |
FTR, most of these problems were fixed by r163110. I'm un-assigning it from myself as this is not a top issue for me anymore, feel free to take over! |
I'm working on a fix for this (and a number of other mangling bugs). |
Fixed by r180250. |
mentioned in issue llvm/llvm-bugzilla-archive#13444 |
Extended Description
Here's a test presented as a diff to test/CodeGenCXX/mangle-ms.cpp
the FIXME lines are the unsatisfied checks, NOW is how these variables are mangled today.
diff --git test/CodeGenCXX/mangle-ms.cpp test/CodeGenCXX/mangle-ms.cpp
index 8798a7d..8440d68 100644
--- test/CodeGenCXX/mangle-ms.cpp
+++ test/CodeGenCXX/mangle-ms.cpp
@@ -2,6 +2,11 @@
// CHECK: @"\01?a@@3Ha"
// CHECK: @"\01?b@N@@3Ha"
+// CHECK: @"\01?s1@N@@3PADA"
+// FIXME: @"\01?s2@N@@3QBDB"
+// NOW: @"\01?s2@N@@3PBDA"
+// FIXME: @"\01?s3@N@@3QBDB"
+// NOW: @"\01?s3@N@@3PBDA"
// CHECK: @c
// CHECK: @"\01?d@foo@@0FB"
// CHECK: @"\01?e@foo@@1jc"
@@ -18,10 +23,17 @@
int a;
-namespace N { int b; }
+namespace N {
+}
static int c;
-int _c(void) {return c;}
+int _c(void) {
+}
// CHECK: @"\01?_c@@yahxz"
class foo {
The text was updated successfully, but these errors were encountered: