-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Wrong mangling of "const char * const *" #13816
Comments
assigned to @timurrrr |
Are you working on this Timur? |
Not yet. |
If you do take over - please pay more attention to the |
More tests: void foo(const double) {} typedef double Vector[3]; void foo(Vector*, const Vector, const double) {} void foo(Vector*) {} |
Taking this |
Good news: I think I've fixed all these issues. |
Thanks for the update. I'll be happy to help review the patch once you post it. |
Should be fixed by r163110. |
... and added more tests in r163111. |
Extended Description
The mangling is broken when using
-cxx-abi microsoft
:$ cat const_arrays.cpp
extern const char* const* global;
// CHECK: "\01?global@@3PBQBDB"
// NOW: "\01?global@@3PQBDA"
// Probably related to #13554
void foo(const char* const* arg) {
// CHECK: "\01?foo@@YAXPBQBD@Z"
// NOW: "\01?foo@@YAXPQBD@Z"
// Probably UN-related to #13554
if (global[0]) arg++;
}
The text was updated successfully, but these errors were encountered: