Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics not restored when temporarily disabled from within PCH #14553

Closed
llvmbot opened this issue Oct 25, 2012 · 3 comments
Closed

Diagnostics not restored when temporarily disabled from within PCH #14553

llvmbot opened this issue Oct 25, 2012 · 3 comments
Labels
bugzilla Issues migrated from bugzilla c++

Comments

@llvmbot
Copy link
Member

llvmbot commented Oct 25, 2012

Bugzilla Link 14181
Resolution FIXED
Resolved on Oct 29, 2012 19:27
Version trunk
OS All
Attachments Testcase for the bug
Reporter LLVM Bugzilla Contributor
CC @akyrtzi,@DougGregor

Extended Description

Diagnostics that are temporarily disabled (using "#pragma clang diagnostic push/pop") from within precompiled headers are not re-enabled in the including file. Find attached a patch that extends the existing PCH-diagnostics-test to also test for this.
@llvmbot
Copy link
Member Author

llvmbot commented Oct 26, 2012

This is affecting my company as well. We include some third-party code in our precompiled headers, and we disable warnings around it. When we do this, we no longer see warnings in any of our code. This is with the version of clang from Xcode 4.5.1:

Apple clang version 4.1 (tags/Apple/clang-421.11.66) (based on LLVM 3.1svn)
Target: x86_64-apple-darwin12.2.0
Thread model: posix

@DougGregor
Copy link
Contributor

cloned to rdar://problem/12581618

@akyrtzi
Copy link
Contributor

akyrtzi commented Oct 30, 2012

Fixed in r166987

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla c++
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akyrtzi @DougGregor @llvmbot