Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColdCC poorly implemented (ignored) on X86/X86_64 #14853

Closed
llvmbot opened this issue Dec 2, 2012 · 1 comment
Closed

ColdCC poorly implemented (ignored) on X86/X86_64 #14853

llvmbot opened this issue Dec 2, 2012 · 1 comment
Labels
bugzilla Issues migrated from bugzilla

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Dec 2, 2012

Bugzilla Link 14481
Resolution FIXED
Resolved on Aug 30, 2013 13:21
Version trunk
OS Linux
Attachments [Example fix for X86https://user-images.githubusercontent.com/60944935/143746452-6f4b5332-6a28-4149-95d6-c5db710c2621.gz)
Reporter LLVM Bugzilla Contributor

Extended Description

Calls to coldcc functions unnecessarily are treated as clobbering registers in the same manner as normal calls. Instead, we should better model the "this call clobbers nothing" property that makes coldcc useful.

Attached is a works-for-me(TM) patch that resolves this issue on x86_64, and might work on X86 as well. Ideally this could be implemented in a more target-agnostic manner, but I'm not sure how to best approach that. I leave that to the good folk more familiar with the related components :).
@llvmbot
Copy link
Collaborator Author

llvmbot commented Aug 30, 2013

Fixed in r175911 (Feb 2013).

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@llvmbot