assigned to @rnk

This has come up multiple times in LLDB coding style discussion and on chromium-dev.

It'd also be nice if we could keep warning when there's ambiguity in the way that the ctor parameter is used, though, as in:

struct Foo {
int i;
Foo(int i) : i(i) { i++; } // modifies the parameter, not member
};

*** Bug llvm/llvm-bugzilla-archive#21110 has been marked as a duplicate of this bug. ***

Yes this generates hundreds of useless warnings!
It should only warn if the name is used inside the constructor body.

+rtrieu in case he's interested in this one

Function of interest is Sema::CheckShadow.

Something along the lines of:

Index: SemaDecl.cpp

--- SemaDecl.cpp (revision 260978)
+++ SemaDecl.cpp (working copy)
@@ -6344,10 +6344,18 @@
return;

// Fields are not shadowed by variables in C++ static methods.

• if (isa(ShadowedDecl))

• if (isa(ShadowedDecl)) {
  if (CXXMethodDecl *MD = dyn_cast(NewDC))
  if (MD->isStatic())
  return;

• if (auto CD = dyn_cast(NewDC)) {

•  if (dyn_cast<ParmVarDecl>(D)) {
  

•    return;
  

•  }
  

• }

• }

  if (VarDecl *shadowedVar = dyn_cast(ShadowedDecl))
  if (shadowedVar->isExternC()) {

Here's something that kind of works but needs more extensive testing:
http://reviews.llvm.org/D18271

r267957. If you want the old behavior, use -Wshadow-all.

Much better now, thanks!

Though it still warns about a similar pattern as some people don't use field name prefixes:

void setFoo(Foo* f) { this->f = f; }
int doBoo(int a, int f) { return a + f; }

mentioned in issue llvm/llvm-bugzilla-archive#21110