New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[-cxx-abi] Out-of-line constructor not emitted if pure virtual functions are present? #17109

Closed

timurrrr opened this issue Jul 29, 2013 · 5 comments

Assignees

Labels

Contributor

timurrrr commented Jul 29, 2013


Bugzilla Link	16735
Resolution	FIXED
Resolved on	Aug 04, 2013 12:32
Version	trunk
OS	Windows NT
Blocks	#12849
CC	@DougGregor,@rnk

Extended Description

As of r187356,

$ clang++ -Xclang -cxx-abi -Xclang microsoft -w -S -o - source.cpp

gives an empty output on this file:

struct X {
X();
virtual void f() = 0;
};

X::X() { }

If another class in a different TU inherits X and overrides f(), we get a link-time unresolved symbol error for the X constructor.

Contributor Author

timurrrr commented Jul 29, 2013

assigned to @timurrrr

Contributor Author

timurrrr commented Jul 29, 2013

FTR, this builds fine if I remove "= 0;"

Contributor Author

timurrrr commented Jul 30, 2013

This looks to be trivial enough, I'll take it.

Contributor Author

timurrrr commented Jul 31, 2013

http://llvm-reviews.chandlerc.com/D1248 out for review

Contributor Author

timurrrr commented Aug 4, 2013

Should be fine after r187709.

llvmbot transferred this issue from llvm/llvm-bugzilla-archive

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment