Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-format incorrectly formats long comments with preprocessor #17910

Closed
llvmbot opened this issue Oct 10, 2013 · 2 comments
Closed

clang-format incorrectly formats long comments with preprocessor #17910

llvmbot opened this issue Oct 10, 2013 · 2 comments
Labels
bugzilla Issues migrated from bugzilla clang-format

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Oct 10, 2013

Bugzilla Link 17536
Resolution FIXED
Resolved on Nov 12, 2013 11:54
Version trunk
OS All
Reporter LLVM Bugzilla Contributor

Extended Description

I'm on Clang r192347.

mblsha@siruba-retina ~> cat clang-format-test.cc
#ifdef ZOMFG //Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
int a;
#endif

mblsha@siruba-retina ~> ~/src/clang-llvm/build-release/bin/clang-format --style=Chromium clang-format-test.cc
#ifdef ZOMFG // Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed
// do eiusmod tempor incididunt ut labore et dolore magna
// aliqua.
int a;
#endif

If '' are required for preprocessor lines, then they're not correctly aligned.
@llvmbot
Copy link
Collaborator Author

llvmbot commented Oct 10, 2013

And the first '' breaks the 80-column limit.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Nov 12, 2013

Fixed in r194491.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 9, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla clang-format
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@llvmbot