Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtractMappedBlocksFromModule discards the "blocks to not extract" list #2147

Closed
llvmbot opened this issue Nov 5, 2007 · 5 comments
Closed

ExtractMappedBlocksFromModule discards the "blocks to not extract" list #2147

llvmbot opened this issue Nov 5, 2007 · 5 comments
Assignees
@nlewycky
Labels
bugzilla Issues migrated from bugzilla tools:bugpoint

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Nov 5, 2007

Bugzilla Link 1775
Resolution FIXED
Resolved on Nov 14, 2007 00:49
Version trunk
OS All
Reporter LLVM Bugzilla Contributor
CC @nlewycky

Extended Description

In tools/bugpoint/ExtractFunction.cpp:ExtractMappedBlocksFromModule, bugpoint is discarding the "blocks to not extract" list since it's doing a fork+exec to run the block extractor pass. bugpoint used to just fork, so it used to work.
@llvmbot
Copy link
Collaborator Author

llvmbot commented Nov 5, 2007

assigned to @nlewycky

@nlewycky
Copy link
Contributor

adds a command-line option to block extractor and makes bugpoint use it
This proposed patch should improve the situation.

This modifies bugpoint to write out the (Function, BasicBlock) names to a file, then passing the name of that file over to the extract basic blocks pass. It isn't perfect, as function and BB names might have spaces, newlines, etc. in them. It'd be cool if that could be fixed by leveraging the .ll parser/printer bits.

@lattner
Copy link
Collaborator

lattner commented Nov 14, 2007

Patch looks great to me, please apply!

@nlewycky
Copy link
Contributor

Applied. The bug for the possible things it won't handle is llvm/llvm-bugzilla-archive#1797 .

@nlewycky
Copy link
Contributor

mentioned in issue llvm/llvm-bugzilla-archive#1797

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlewycky nlewycky

Labels
bugzilla Issues migrated from bugzilla tools:bugpoint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nlewycky @lattner @llvmbot