Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinPackParameters with Cpp11BracedListStyle causes very long struct inits #20997

Closed
nico opened this issue Aug 11, 2014 · 1 comment
Closed

BinPackParameters with Cpp11BracedListStyle causes very long struct inits #20997

nico opened this issue Aug 11, 2014 · 1 comment
Labels
bugzilla Issues migrated from bugzilla clang-format

Comments

@nico
Copy link
Contributor

nico commented Aug 11, 2014

Bugzilla Link 20623
Resolution FIXED
Resolved on Aug 13, 2014 03:47
Version unspecified
OS All

Extended Description

issue 19359 made it so that Cpp11BracedListStyle with BinPackParameters uses one thing per line.

Most of the time that's good, but pdfium has fairly large data tables that now takes many thousands of lines due to this: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/pdfium/core/src/fpdfapi/fpdf_cmaps/CNS1/UniCNS-UCS2-H_3.cpp&q=UniCNS-UCS2-H_3.cpp&sq=package:chromium&type=cs

I'm not sure if there's a good solution.

(I'm going to try formatting pdfium with Cpp11BracedListStyle turned off, I think.)
@llvmbot
Copy link
Member

llvmbot commented Aug 13, 2014

Fixed in r215529 by special-casing long lists (with 20 or more items).

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 9, 2021
@gedare gedare mentioned this issue Oct 16, 2024
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla clang-format
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nico @llvmbot