Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orc needs unit tests. #22982

Closed
lhames opened this issue Feb 17, 2015 · 5 comments
Closed

Orc needs unit tests. #22982

lhames opened this issue Feb 17, 2015 · 5 comments
Labels
bugzilla Issues migrated from bugzilla orcjit

Comments

@lhames
Copy link
Contributor

lhames commented Feb 17, 2015

Bugzilla Link 22608
Resolution FIXED
Resolved on May 21, 2019 14:27
Version trunk
OS All
CC @AlexDenisov,@dwblaikie,@weliveindetail

Extended Description

As the title says.

The Orc APIs should lend themselves to unit tests, and this may allow us to reduce our reliance on the JIT regression tests, which often have problems with portability.
@lhames
Copy link
Contributor Author

lhames commented Feb 17, 2015

Adding Anthony, who was interested in general JIT stuff.

@lhames
Copy link
Contributor Author

lhames commented Feb 23, 2015

Initial unit test checked in by Dave Blaikie in r230196.

Now I've got something to crib from when adding more tests. Thanks Dave!

@lhames
Copy link
Contributor Author

lhames commented Mar 2, 2016

Progress report:

We now have several unit tests for portions of the ORC APIs.

Still to do - several of the layers are still untested, and there are no tests for the generic layer concept.

@weliveindetail
Copy link
Contributor

How is (unit) test coverage today in Orc?

@lhames
Copy link
Contributor Author

lhames commented May 21, 2019

Improved! Plenty of infrastructure and basic tests are in place now. I'm going to call this fixed. :)

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 9, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla orcjit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lhames @weliveindetail