Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression(241926): opus no longer builds when targeting arm #24564

Closed
nico opened this issue Jul 20, 2015 · 10 comments
Closed

Regression(241926): opus no longer builds when targeting arm #24564

nico opened this issue Jul 20, 2015 · 10 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla clang:codegen

Comments

@nico
Copy link
Contributor

nico commented Jul 20, 2015

Bugzilla Link 24190
Resolution FIXED
Resolved on Jul 20, 2015 19:20
Version trunk
OS All
Blocks #24500
CC @zmodem,@MatzeB

Extended Description

I'm hitting the following on one of our bots when trying to update clang:

/tmp/encode_frame_FIX-637210.s: Assembler messages:
/tmp/encode_frame_FIX-637210.s:917: Error: r13 not allowed here -- `ldrd sp,r0,[r6,#12]'

Will try to come up with a reduced repro.

@nico
Copy link
Contributor Author

nico commented Jul 20, 2015

assigned to @MatzeB

@nico
Copy link
Contributor Author

nico commented Jul 20, 2015

thakis@yearofthelinuxdesktop:/src/delta$ cat repro.i
typedef struct {
int xq[1632];
int ltp_mem_length;
int prefillFlag;
} silk_encoder_state;
typedef struct { silk_encoder_state sCmn; } silk_encoder_state_FIX;
typedef struct { int Gains_Q16[6]; } silk_encoder_control_FIX;
int a;
silk_encoder_control_FIX b;
void fn2(silk_encoder_control_FIX);
void fn3(silk_encoder_control_FIX, int*);
void fn1(silk_encoder_state_FIX *p1) {
if (p1->sCmn.prefillFlag) {
int c[p1->sCmn.ltp_mem_length];
fn2(b);
fn3(b, c);
}
if (p1->sCmn.prefillFlag)
a = 0;
}
thakis@yearofthelinuxdesktop:
/src/delta$ ~/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang -fstack-protector -fvisibility=hidden -fPIC -target arm-linux-gnueabihf -march=armv8-a -no-integrated-as -mthumb -O2 -c repro.i
/tmp/repro-7a2037.s: Assembler messages:
/tmp/repro-7a2037.s:86: Error: r13 not allowed here -- `ldrd sp,r0,[r7,#-28]'
clang: error: assembler command failed with exit code 1 (use -v to see invocation)

@zmodem
Copy link
Collaborator

zmodem commented Jul 20, 2015

Marking this as a blocker for 3.7 in case this regressed before the branch happened.

@nico
Copy link
Contributor Author

nico commented Jul 20, 2015

bad at r242000

@nico
Copy link
Contributor Author

nico commented Jul 21, 2015

maybe 241920?

@nico
Copy link
Contributor Author

nico commented Jul 21, 2015

maybe not r241920, doesn't seem to repro there

@nico
Copy link
Contributor Author

nico commented Jul 21, 2015

It's r241926

@nico
Copy link
Contributor Author

nico commented Jul 21, 2015

matze reverted in r242733-242735. He also said on IRC he'll have a fix in a few hours, so maybe we can merge the fix to the branch instead of the reverts.

@zmodem
Copy link
Collaborator

zmodem commented Jul 21, 2015

matze reverted in r242733-242735. He also said on IRC he'll have a fix in a
few hours, so maybe we can merge the fix to the branch instead of the
reverts.

OK, keep me posted.

@MatzeB
Copy link
Contributor

MatzeB commented Jul 21, 2015

I fixed the issue and re-applied the patches in r242742 and r242743.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla clang:codegen
Projects
None yet
Development

No branches or pull requests

3 participants