Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modernize-redundant-void-arg doesn't detect problems inc included files #26268

Closed
EugeneZelenko opened this issue Dec 19, 2015 · 6 comments
Closed

modernize-redundant-void-arg doesn't detect problems inc included files #26268

EugeneZelenko opened this issue Dec 19, 2015 · 6 comments
Assignees
@LegalizeAdulthood
Labels
bugzilla Issues migrated from bugzilla clang-tidy

Comments

@EugeneZelenko
Copy link
Contributor

Bugzilla Link 25894
Resolution FIXED
Resolved on Feb 16, 2016 18:34
Version unspecified
OS Linux
CC @LegalizeAdulthood

Extended Description

modernize-redundant-void-arg doesn't detect problems inc included files (trunk version as of r255909).

Problem could be reproduced by moving part of test into other file and include it in test.
@EugeneZelenko
Copy link
Contributor Author

assigned to @LegalizeAdulthood

@LegalizeAdulthood
Copy link
Contributor

You can assign this to me, I'll probably have a fix ready for review over the Christmas break.

@LegalizeAdulthood
Copy link
Contributor

OK, looks like I can assign it to myself, so never mind :)

@llvmbot
Copy link
Collaborator

llvmbot commented Dec 23, 2015

It looks like you just need to remove isExpansionInMainFile from all matchers in this check (and the readability-simplify-boolean-expr check as well). Clang-tidy takes care of filtering the results by file itself.

@EugeneZelenko
Copy link
Contributor Author

It looks like you just need to remove isExpansionInMainFile from all
matchers in this check (and the readability-simplify-boolean-expr check as
well). Clang-tidy takes care of filtering the results by file itself.

I tried to remove isExpansionInMainFile() from RedundantVoidArgCheck.cpp and check worked for me in case of included files.

@EugeneZelenko
Copy link
Contributor Author

Fixed in r260948.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LegalizeAdulthood LegalizeAdulthood

Labels
bugzilla Issues migrated from bugzilla clang-tidy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LegalizeAdulthood @EugeneZelenko @llvmbot