google-readability-namespace-comments check does the wrong thing for macro id tokens on closing namespace #26648
Labels
Comments
|
It was fixed in commit: Review can be found here: https://reviews.llvm.org/D69855 I will close this bug now. |
|
Reverted 4736d63, because it introduces false positives. Sent out an alternative fix: https://reviews.llvm.org/D70974 |
|
The new fix has landed in commit fac4e3c. |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Extended Description
Consider:
#define MY_NAMESPACE foo
namespace MY_NAMESPACE {
} // namespace MY_NAMESPACE
clang-tidy wants to change the last line to
} // namespace foo. It shouldn't. (Fix: If the namespace name is a macro token, check if the macro name matches what's in the closing comment, and don't change that if so.)https://codereview.chromium.org/1629693002/diff/1/base/containers/hash_tables.h
The text was updated successfully, but these errors were encountered: