Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register coalescer introduces verifier error #27179

Closed
arsenm opened this issue Mar 2, 2016 · 9 comments
Closed

Register coalescer introduces verifier error #27179

arsenm opened this issue Mar 2, 2016 · 9 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla llvm:regalloc

Comments

@arsenm
Copy link
Contributor

arsenm commented Mar 2, 2016

Bugzilla Link 26805
Resolution FIXED
Resolved on Mar 04, 2016 22:36
Version trunk
OS All
CC @qcolombet

Extended Description

The XFAILed test in test/CodeGen/AMDGPU/reg-coalescer-sched-crash.ll is a
verifier error introduced by the register coalescer. I think it has something to do with rematerializing an instruction into a sub register when the super register isn't fully defined.

@arsenm
Copy link
Contributor Author

arsenm commented Mar 2, 2016

assigned to @MatzeB

@arsenm
Copy link
Contributor Author

arsenm commented Mar 2, 2016

This is a reduced testcase from an OpenCV regression

@qcolombet
Copy link
Collaborator

Is this new?
I.e., is this a regression and if yes, what introduced it?

@arsenm
Copy link
Contributor Author

arsenm commented Mar 2, 2016

Is this new?
I.e., is this a regression and if yes, what introduced it?

The regression showed up in r251860, so I think this was uncovering a existing problem.

@MatzeB
Copy link
Contributor

MatzeB commented Mar 2, 2016

I think this bug always existed, it only affects targets with acticated subregister liveness. We already had a longer IRC session analyzing it (just have to grep my logs when I start working on it), so I'll look into it.

@qcolombet
Copy link
Collaborator

I think this bug always existed, it only affects targets with acticated
subregister liveness. We already had a longer IRC session analyzing it (just
have to grep my logs when I start working on it), so I'll look into it.

Sounds good.
Thanks both.

For the sake of future archeology ;), would you mind summarizing the content of the IRC discussion?

@MatzeB
Copy link
Contributor

MatzeB commented Mar 2, 2016

For the sake of future archeology ;), would you mind summarizing the content of the IRC discussion?

Sorry I can't remember the details (intricate stuff in the rematerialization logic of the register coalescer). Once there is a fix it is hopefully clear that the problem was :)

@qcolombet
Copy link
Collaborator

For the sake of future archeology ;), would you mind summarizing the content of the IRC discussion?

Sorry I can't remember the details (intricate stuff in the rematerialization
logic of the register coalescer). Once there is a fix it is hopefully clear
that the problem was :)

Fair enough :).

@MatzeB
Copy link
Contributor

MatzeB commented Mar 5, 2016

Fixed in r262768

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla llvm:regalloc
Projects
None yet
Development

No branches or pull requests

3 participants