-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ms] clang-cl fails to compile sample MDIDocVw from WTL (header atlframe.h) #27711
Comments
assigned to @dmpolukhin |
The code is obviously ill-formed; the question is, does it make sense for us to be compatible with this MSVC bug? If this only occurs in sample code, that doesn't seem like a very compelling case to me. If this also occurs in a large quantity of real code derived from those samples, that would be more persuasive. |
Also, have you contacted the authors of this code to let them know their samples are broken? |
Actually not, I just wanted to know whether clang can compile WTL/ATL headers.
Yes, I understand that such code has no sense and I'm ok with closing PR as Resolved Invalid. But anyway I wanted to report that there is ms bug that allows users to compile code from real samples that clang is not able to compile. |
Fixed by http://reviews.llvm.org/D19477 |
Reverted by r267865. |
/Gr), by Alexander Makarov Patch for bug llvm#27711 Differential Revision: http://reviews.llvm.org/D20171 llvm-svn: 269891
Extended Description
!- compilation of WTL example WTL/MDIDocVw fails with clang. MS can compile the whole project without any errors.
These problems also appear during compilation of this sample:
26735
26748
-!
========Environment==============
Os: Win
Language: C++
Version: trunk
========Reproducer================
========Small Reproducer==========
/code from include/atlframe.h/
template
class CUpdateUI
{
public:
CUpdateUI()
{
T* pT = static_cast<T*>(this);
}
};
/code from sample WTL/MDIDocVw (mainfrm.h )/
class CMDIFrame : CUpdateUI
{
public:
};
/* default constructor is called in MDI.cpp*/
int main (){
CMDIFrame wndMain;
return 0;
}
=============Error==================
Andrey Kuleshov
Software Engineer
Intel Compiler Team
The text was updated successfully, but these errors were encountered: