Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCEV not sufficiently invalidated - Results in non-dominating expressions to be inserted #29354

Closed
tobiasgrosser opened this issue Aug 15, 2016 · 2 comments
Closed

SCEV not sufficiently invalidated - Results in non-dominating expressions to be inserted #29354

tobiasgrosser opened this issue Aug 15, 2016 · 2 comments
Labels
bugzilla Issues migrated from bugzilla polly

Comments

@tobiasgrosser
Copy link
Contributor

Bugzilla Link 28984
Resolution FIXED
Resolved on Aug 18, 2016 05:46
Version unspecified
OS Linux

Extended Description

opt -polly-process-unprofitable -polly-remarks-minimal -S -polly-codegen
-polly-invariant-load-hoisting=false test/Isl/CodeGen/hoisted_load_escapes_through_phi.ll

fails with r78673:

%tmp1 = load i32, i32* @​cont_STACKPOINTER, align 4
%0 = sext i32 %tmp1 to i64
Polly generated function could not be verified. Add -polly-codegen-verify=false to disable this assertion.

The test case contains two scops in a row, where the first scop is code generated "before" the second scop. Unfortunately the second scop references the first scop in some of the SCEV expressions used, which results in parameter values of the second scop referencing an instruction ('tmp1') which is not any more dominating the second scop.

We probably need to run SE.forgetValue() for all instruction in the original scop region. However, this might conflict with the caching of SCEV instructions in ScopDetection.
@tobiasgrosser
Copy link
Contributor Author

Fixed in r279047.

@tobiasgrosser
Copy link
Contributor Author

mentioned in issue llvm/llvm-bugzilla-archive#28985

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla polly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tobiasgrosser