I have to first edit the comment for this to happen apparently.

Hi Mehdi,

Do you mean unposted inline comments or comments to the patch?

I've tried deleting unposted inline comments by clicking the "trash" button, which always worked. I tested with Chrome browser; which browser and version are you using?

For comments to the patch, there is no "delete" button. The comment is deleted when you delete all the text, although the comment preview might not be updated immediately after you delete the text.

• Eric

I'm talking about unposted inline comments.

Have you tried first editing and saving it before trying to delete it?

FWIW, I ran into this same issue. I tried editing the comment to be empty and saving, but it was not allowed. I tried editing the comment to not be empty and saving, then deleting. The save worked, but the delete still failed. Eventually, I edited the comment to complain about the phab bug and hit submit.

I have not had this issue with all comments I try to delete. It's only happened to me one time, and I'm not certain what steps I took to get me into the weird state.

The same just happened to me. I can reliably reproduce it by:

• Add inline comment to some line in the source, save it.
• Edit the comment, slightly changing the text.
• Press the remove button, they comment becomes greyed out but does not disappear and will be back once you reload the page.

Moved to Website/Phabricator (see #29736 )

Thanks Matthias! I can finally reproduce this. I'll check if this is caused by my local Phab modification. Otherwise, I'll check if this is fixed in Phab upstream or report the issue there.

Friendly ping?

Sorry that I lost track of this issue.

This only happens in the production instance but not the testing instance (with the same revision and local changes), so I couldn't report the issue to Phabricator upstream with a reproducer. I tried hunting the bug myself but failed (Unfortunately, I am not a phabricator or php expert :(

I can try syncing to upstream head to see if this can be magically fixed.

This only happens in the production instance but not the testing instance

Well that's a bummer. Maybe it's load/timing related.

I can try syncing to upstream head to see if this can be magically fixed.

That would certainly be appreciated. If nothing else maybe it will fix some of the other outstanding issues.

Looks like the recent phabricator upgrade resolved this issue.

Could you please check if this is fixed for you? Thanks!

I can't speak to the comment-deletion bug (I was never able to reproduce on-command, so if you were, I believe you when you say that it's better now).

Unfortunately now I cannot select text inside of inline phab comments. (Chrome 55, Ubuntu.)

The comment deletion bug is fixed.
@​jlebar: I am not exactly sure what you mean, but selecting text in the inline comment box within the sourcecode and in the same text in that timeline view above the code with the mouse for copy&pasting work for me on Safari and chrome 55.0.2883.95 on macOS.

@​jlebar: I am not exactly sure what you mean, but selecting text in the
inline comment box within the sourcecode and in the same text in that
timeline view above the code with the mouse for copy&pasting work for me on
Safari and chrome 55.0.2883.95 on macOS.

Yes, I think we're talking about the same thing.

STR for me: Load https://reviews.llvm.org/D28794, ctrl+f, search for "is there a reason". There are two instances of this phrase in the page.

The first instance appears outside of the patch body. I can highlight this fine. The second instance appears inside of the patch body. I am unable to highlight this text using my mouse cursor.

@​jlebar: I am not exactly sure what you mean, but selecting text in the
inline comment box within the sourcecode and in the same text in that
timeline view above the code with the mouse for copy&pasting work for me on
Safari and chrome 55.0.2883.95 on macOS.

Yes, I think we're talking about the same thing.

STR for me: Load https://reviews.llvm.org/D28794, ctrl+f, search for "is
there a reason". There are two instances of this phrase in the page.

The first instance appears outside of the patch body. I can highlight this
fine. The second instance appears inside of the patch body. I am unable to
highlight this text using my mouse cursor.

Yes this works for me on macOS.

@​jlebar: I am not exactly sure what you mean, but selecting text in the
inline comment box within the sourcecode and in the same text in that
timeline view above the code with the mouse for copy&pasting work for me on
Safari and chrome 55.0.2883.95 on macOS.

Yes, I think we're talking about the same thing.

STR for me: Load https://reviews.llvm.org/D28794, ctrl+f, search for "is
there a reason". There are two instances of this phrase in the page.

The first instance appears outside of the patch body. I can highlight this
fine. The second instance appears inside of the patch body. I am unable to
highlight this text using my mouse cursor.

Yes this works for me on macOS.

Also works for me on Windows 10 with Chrome 55.0.2883.87 m.

Closing this as we're no longer using https://reviews.llvm.org for patch reviews.

@JOE1994 Can you use obsolete label for such issues?

@JOE1994 Can you use obsolete label for such issues?

I'll update such tickets that I've closed so far with the obsolete label.