Hi David,

Thanks for reporting this issue.
Owen just uploaded a patch for it here: https://reviews.llvm.org/D30704

Could you please verify if that fixes your issue?

Thanks,
Andrea

Could you please verify if that fixes your issue?

No it doesn't. Proposed solution misses the point.

For loop still has inclusive upper and lower limits,
which is IMHO a newbie off by one error.

Every C programmer should know that lower limits are inclusive and
upper limits are exclusive.

Suggest have another look at my proposed solution.

Could you please verify if that fixes your issue?

No it doesn't. Proposed solution misses the point.

For loop still has inclusive upper and lower limits,
which is IMHO a newbie off by one error.

Every C programmer should know that lower limits are inclusive and
upper limits are exclusive.

Suggest have another look at my proposed solution.

If you think that his patch is not okay, then perhaps leave comment on the code review. I posted that message on Owen's behalf since he didn't have a bugzilla account and he had to leave the office.

I'm writing this on Owen's behalf. He requested a bugzilla login a few days ago, but it hasn't yet been created.

Hi David,

Thanks for looking into this revision, after looking further into the issue you describe I have found that a fix is not required.

Unfortunately your suggested change will break the algorithm. The final pass in the loop is required so a remaining token can be pushed into the Args vector (line 392 to 406). As the bug regards access using the [] operator I uploaded a new revision, however I have abandoned this change due to the following in the C++11 standard:

21.4.5 basic_string element access
operator[](size_type pos);
Requires: pos <= size().
Returns: *(begin() + pos) if pos < size(), otherwise a reference to an object of type T with value charT(); the referenced value shall not be modified.

This means that the operator[str.size()] will return '\0'

Looking at your first post it appears to include an error message. Could you please describe the method used to find this?

Thanks,

Owen

This means that the operator[str.size()] will return '\0'

News to me. Thanks for the information.

Looking at your first post it appears to include an error message. Could you
please describe the method used to find this?

I used cppcheck, a C/C++ static analyser.

http://cppcheck.sourceforge.net/

I find it very useful.

Overzealous cppcheck warning