Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge r294690 into the 4.0 branch #31549

Closed
tstellar opened this issue Mar 9, 2017 · 8 comments
Closed

Merge r294690 into the 4.0 branch #31549

tstellar opened this issue Mar 9, 2017 · 8 comments
Assignees
@chandlerc
Labels
bugzilla Issues migrated from bugzilla lld

Comments

@tstellar
Copy link
Collaborator

tstellar commented Mar 9, 2017

Bugzilla Link 32201
Resolution FIXED
Resolved on May 18, 2017 19:07
Version unspecified
OS All
Blocks #31409
CC @zmodem

Extended Description

Is this patch OK to merge to the 4.0 branch?
@tstellar
Copy link
Collaborator Author

tstellar commented Mar 9, 2017

assigned to @chandlerc

@rui314
Copy link
Member

rui314 commented Mar 9, 2017

Hans, what do you think?

@zmodem
Copy link
Collaborator

zmodem commented Mar 10, 2017

I'm not a CMake expert, but it looks good as far as I can tell.

Watch out when merging, r294690 is touching both llvm and lld.

@tstellar
Copy link
Collaborator Author

*** Bug llvm/llvm-bugzilla-archive#32224 has been marked as a duplicate of this bug. ***

@tstellar
Copy link
Collaborator Author

Chandler, is this OK to merge?

@chandlerc
Copy link
Member

LGTM

@tstellar
Copy link
Collaborator Author

Merged:
llvm: r303399
lld: r303400
clang-tools-extra: r303401

@tstellar
Copy link
Collaborator Author

mentioned in issue llvm/llvm-bugzilla-archive#32224

@jsonn jsonn mentioned this issue Feb 24, 2017
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chandlerc chandlerc

Labels
bugzilla Issues migrated from bugzilla lld
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rui314 @tstellar @chandlerc @zmodem