Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/xray/tests/unit/xray_fdr_log_printer_tool.cc should include <functional> #31660

Closed
llvmbot opened this issue Mar 16, 2017 · 2 comments
Closed
Labels
bugzilla Issues migrated from bugzilla xray

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 16, 2017

Bugzilla Link 32313
Resolution FIXED
Resolved on Mar 16, 2017 19:52
Version unspecified
OS Linux
Reporter LLVM Bugzilla Contributor

Extended Description

building with gcc trunk shows:

/home/markus/llvm/projects/compiler-rt/lib/xray/tests/unit/xray_fdr_log_printer_tool.cc: In function ‘int main(int, char**)’:
/home/markus/llvm/projects/compiler-rt/lib/xray/tests/unit/xray_fdr_log_printer_tool.cc:284:30: error: ‘function’ is not a member of ‘std’
std::map<std::string, std::function<void(std::istream &)>> TopLevelRecordMap;
^~~~~~~~
/home/markus/llvm/projects/compiler-rt/lib/xray/tests/unit/xray_fdr_log_printer_tool.cc:284:30: note: suggested alternative: ‘is_function’
std::map<std::string, std::function<void(std::istream &)>> TopLevelRecordMap;
^~~~~~~~
is_function
/home/markus/llvm/projects/compiler-rt/lib/xray/tests/unit/xray_fdr_log_printer_tool.cc:284:30: error: ‘function’ is not a member of ‘std’
/home/markus/llvm/projects/compiler-rt/lib/xray/tests/unit/xray_fdr_log_printer_tool.cc:284:30: note: suggested alternative: ‘is_function’
std::map<std::string, std::function<void(std::istream &)>> TopLevelRecordMap;
^~~~~~~~
is_function
/home/markus/llvm/projects/compiler-rt/lib/xray/tests/unit/xray_fdr_log_printer_tool.cc:284:59: error: template argument 2 is invalid
std::map<std::string, std::function<void(std::istream &)>> TopLevelRecordMap;
^~
/home/markus/llvm/projects/compiler-rt/lib/xray/tests/unit/xray_fdr_log_printer_tool.cc:284:59: error: template argument 4 is invalid
...

diff --git a/lib/xray/tests/unit/xray_fdr_log_printer_tool.cc b/lib/xray/tests/unit/xray_fdr_log_printer_tool.cc
index a4d05f200de5..6e209809e346 100644
--- a/lib/xray/tests/unit/xray_fdr_log_printer_tool.cc
+++ b/lib/xray/tests/unit/xray_fdr_log_printer_tool.cc
@@ -17,6 +17,7 @@
#include
#include
#include
+#include
#include
#include
#include

fixes the issue.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Mar 17, 2017

Thanks for the report, this should be easy enough to fix.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Mar 17, 2017

Should be fixed in r298037 (https://reviews.llvm.org/rL298037)

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla xray
Projects
None yet
Development

No branches or pull requests

1 participant