Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge r298687 into the 4.0 branch : NewGVN: Fix #32403 - Handling of undef in phis was not quite correct #31754

Closed
tstellar opened this issue Mar 24, 2017 · 9 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla wontfix Issue is real, but we can't or won't fix it. Not invalid

Comments

@tstellar
Copy link
Collaborator

Bugzilla Link 32407
Resolution WONTFIX
Resolved on May 19, 2017 11:53
Version 4.0
OS All
Blocks #31409

Extended Description

Is this patch OK to merge to the 4.0 branch?

@tstellar
Copy link
Collaborator Author

assigned to @tstellar

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 24, 2017

I think so.

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 24, 2017

Yes.

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 24, 2017

Note that this revision is the strictly smallest fix.
I refactored it into a faster test that usually does not require checking all members of the congruence class.

But i don't expect this to occur commonly enough to ever matter performance wise.

@tstellar
Copy link
Collaborator Author

tstellar commented Apr 4, 2017

This commit depends on r297424, which we can't merge because it breaks the ABI.

@llvmbot
Copy link
Collaborator

llvmbot commented Apr 4, 2017

Two options:
1.It's possible to rework the code to not depend on that if you like.
It should just be de-constifying some tings
2. You can avoid breaking the ABI by just adding back the old versions of the count and lookup functions, no?

@tstellar
Copy link
Collaborator Author

Is anyone interested in fixing up this patch to merge?

@llvmbot
Copy link
Collaborator

llvmbot commented May 19, 2017

There's more you'd have to merge as i'm about to fix pr32838, a related issue.

Unless someone has a strong urge to have it in 4.0, ...

@llvmbot
Copy link
Collaborator

llvmbot commented May 19, 2017

Thanks for pinging and reminding me of this one, Tom!
I'm making a call here and resolving it as WONTFIX.
Backporting just this very issue isn't really helping as in the meanwhile we fixed a bunch of miscompiles/crashes/etc..

Backporting all of them seems unrealistic in the 4.0.1 timeframe.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
@Quuxplusone Quuxplusone added the wontfix Issue is real, but we can't or won't fix it. Not invalid label Jan 20, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla wontfix Issue is real, but we can't or won't fix it. Not invalid
Projects
None yet
Development

No branches or pull requests

3 participants