New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge r292188 and r292246 into 4.0.1 (fixes bug 32494, and possibly others) #31842
Comments
assigned to @tstellar |
Is this OK to merge? |
Davide or Eli, are these patches OK for the 4.0.1 branch? |
This has been in tree for a while, and it seems to be useful to the FreeBSD folks. I think it's OK to merge this to 4.0.1 in some form. Backporting the MSVC warning fix seems a no-brainer to me (assuming the other patch gets backported). |
Dimitry, is there a specific bug this patch fixes? I agree that it would be nice to merge a subset of this patch if possible. |
Yes, bug 32494, as mentioned in the description. Basically, this fixes |
Even though it crashes in the log1p bultin, the fact that the code is a conftest.c generated by autoconf makes me wonder if this is a generic bug that would potentially affected all builtins, or if the log1p case is special. Are you able to patch 4.0.0 with only the log1p fix from this patch and see if you hit any other failures? |
log1p Fix |
Yes, that works indeed, for the specific case of log1p. Should be fine for 4.0.1. |
Merged: r303992 |
Extended Description
Please merge the following into 4.0.1:
https://reviews.llvm.org/rL292188
https://reviews.llvm.org/rL292246
The former is a fix for bug 32494 (and possibly others), the latter a follow-up fix to eliminate MSVC warnings.
The text was updated successfully, but these errors were encountered: