Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge r301328 into the 4.0 branch : [libclang] Check for a record declaration before a template specialization #32141

Closed
emilio opened this issue Apr 25, 2017 · 6 comments
Closed

Merge r301328 into the 4.0 branch : [libclang] Check for a record declaration before a template specialization #32141

emilio opened this issue Apr 25, 2017 · 6 comments
Assignees
@zygoloid
Labels
bugzilla Issues migrated from bugzilla wontfix Issue is real, but we can't or won't fix it. Not invalid

Comments

@emilio
Copy link
Contributor

emilio commented Apr 25, 2017

Bugzilla Link 32794
Resolution WONTFIX
Resolved on May 23, 2017 10:31
Version 4.0
OS All
Blocks #31409
CC @tstellar

Extended Description

Is this patch OK to merge to the 4.0 branch?
@emilio
Copy link
Contributor Author

emilio commented Apr 25, 2017

assigned to @zygoloid

@tstellar
Copy link
Collaborator

Hi Richard,

Is this OK to merge to the 4.0 branch?

@zygoloid
Copy link
Mannequin

zygoloid mannequin commented Apr 26, 2017

I've asked some questions on the review thread (https://reviews.llvm.org/D32348); this change alone seems to introduce inconsistency and potentially a regression compared to 4.0.

@tstellar
Copy link
Collaborator

r301328 was reverted, so it won't be merged into 4.0. However, since r301328 fixed a regression introduced by r287024, should we revert r287024 in the 4.0 branch?

@zygoloid
Copy link
Mannequin

zygoloid mannequin commented May 19, 2017

See https://reviews.llvm.org/D32566 for discussion. I think the conclusion there was to leave the existing 4.0 behavior alone, at least for 4.0.1.

@tstellar
Copy link
Collaborator

OK, we won't merge this patch then.

@jsonn jsonn mentioned this issue Feb 24, 2017
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
@Quuxplusone Quuxplusone added the wontfix Issue is real, but we can't or won't fix it. Not invalid label Jan 20, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zygoloid zygoloid

Labels
bugzilla Issues migrated from bugzilla wontfix Issue is real, but we can't or won't fix it. Not invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tstellar @Quuxplusone @emilio