Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLVM-COV] A non-executed label was wrongly marked as executed in llvm-cov #34774

Closed
llvmbot opened this issue Nov 26, 2017 · 4 comments
Closed
Labels
bugzilla Issues migrated from bugzilla clang Clang issues not falling into any other category

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Nov 26, 2017

Bugzilla Link 35426
Resolution FIXED
Resolved on Apr 12, 2018 23:19
Version trunk
OS Linux
Reporter LLVM Bugzilla Contributor
CC @def-,@vedantk

Extended Description

$ clang -v
clang version 6.0.0-svn318792-1~exp1 (trunk)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/5
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.1
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/6
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/7
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/7.2.0
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/5
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/5.4.1
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/6
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/6.3.0
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/7
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/7.2.0
Selected GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/7.2.0
Candidate multilib: .;@m64
Selected multilib: .;@m64

$ cat small.c
int main()
{
int i=1, j=1, k=1;
if (i > 0) {
if (j == 1) {
if (k == 1)
return 0;
else
goto lbl;
} else {
;
}
}
lbl:
return 1;
}

$ clang -w -O0 -g -fcoverage-mapping -fprofile-instr-generate=small.profraw small.c; ./a.out; llvm-profdata merge small.profraw -o small.profdata; llvm-cov show a.out -instr-profile=small.profdata small.c > small.gcov

$ cat small.gcov
1| |int main()
2| 1|{
3| 1| int i=1, j=1, k=1;
4| 1| if (i > 0) {
5| 1| if (j == 1) {
6| 1| if (k == 1)
7| 1| return 0;
8| 0| else
9| 0| goto lbl;
10| 0| } else {
11| 0| ;
12| 0| }
13| 1| }
14| 1|lbl:
15| 0| return 1;
16| 0|}

Line #​14 is a label. The goto statement is not executed. However, it was wrongly marked as executed in llvm-cov. While removing Line #​10 and #​11 from this code, this result is correct.

@vedantk
Copy link
Collaborator

vedantk commented Nov 30, 2017

Thank you for the report. This is a bug in the coverage segment builder, where I missed a corner case. Fixed in r319391

@vedantk
Copy link
Collaborator

vedantk commented Nov 30, 2017

*** Bug #34742 has been marked as a duplicate of this bug. ***

@llvmbot
Copy link
Collaborator Author

llvmbot commented Nov 30, 2017

Thanks a lot.

Thank you for the report. This is a bug in the coverage segment builder,
where I missed a corner case. Fixed in r319391

@vedantk
Copy link
Collaborator

vedantk commented Nov 27, 2021

mentioned in issue llvm/llvm-bugzilla-archive#35437

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla clang Clang issues not falling into any other category
Projects
None yet
Development

No branches or pull requests

2 participants