-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chromium aarch64 builds fail with "Cannot select: t33: f64 = AArch64ISD::FMOV Constant:i32<0>" #35717
Comments
Bisection points to this one: Author: evandro URL: http://llvm.org/viewvc/llvm-project?rev=324903&view=rev Get rid of icky goto loops and make the code easier to maintain (NFC). Differential revision: https://reviews.llvm.org/D42723 Modified:
|
Reverted in r325034 in the meantime |
Would it be possible to attach a preprocessed version of the offending code, please? |
It was too large to attach here directly, so I added it to |
That file doesn't seem to be the preprocessed output that results when the -E option is specified. I'm still getting too many compilation errors and cannot confirm the fix for it. Please, attach the .i file to the Chromium bug as well. |
Posted fix for review at https://reviews.llvm.org/D42133 |
It's the reproducer created by clang when it crashed. I think that means it's got all the #include files pulled in, but it still has other preprocessor directives. Attaching a preprocessed version which shows the error when invoked as: $ clang -cc1 -triple aarch64--linux-android -emit-obj -target-cpu generic -target-feature +neon -target-abi aapcs -Oz -std=gnu++14 -vectorize-slp -x c++ /tmp/a.ii |
I applied this on top of r324903 but still get the same error using the repro in #c7. |
Oh, or did you mean https://reviews.llvm.org/D43364 ? I applied this too, but still get the same failure. |
Got it narrowed down to: define void @v2i32st(<2 x i32>* %p) nounwind { Thank you! |
Please, confirm solution in https://reviews.llvm.org/D43364. Thank you. |
Yes, that seems to work. |
I'd appreciate if you could review the patch too. Thanks for confirming this bug fixed. |
Sorry, I don't know anything about aarch64 isel, so I'm not a good reviewer for this. |
Extended Description
See https://bugs.chromium.org/p/chromium/issues/detail?id=811767#c1 for reproducer.
The text was updated successfully, but these errors were encountered: