Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check lines generated by update_mca_test_checks.py don't break upon new lines #37219

Open
LebedevRI opened this issue Jun 20, 2018 · 6 comments
Labels
bugzilla Issues migrated from bugzilla llvm-tools All llvm tools that do not have corresponding tag

Comments

@LebedevRI
Copy link
Member

Bugzilla Link 37871
Version trunk
OS Linux
CC @adibiagio,@legrosbuffle,@gregbedwell,@MaskRay,@RKSimon

Extended Description

E.g. try with r335099 ([X86][Znver1] Specify Register Files, RCU; FP scheduler capacity.)
If you undo the check changes, reset the test state to before this commit,
and do ninja check-llvm-tools-llvm-mca, it will still pass.
Even though there are new lines in the output.
They aren't being accounted for.

@gregbedwell
Copy link
Collaborator

I don't entirely understand the description. Sorry!

If I'm reading it right, the issue is that the generated checks are checking for the presence of expected lines, but they are not checking for the absence of unexpected lines. Do I understand that correctly?

@LebedevRI
Copy link
Member Author

If I'm reading it right, the issue is that the generated checks are checking
for the presence of expected lines, but they are not checking for the
absence of unexpected lines. Do I understand that correctly?

Yes.

@gregbedwell
Copy link
Collaborator

I knocked up a quick prototype that has stricter checking, but currently relies on this (uncommitted) patch: https://reviews.llvm.org/D28896

Obviously, if we go ahead with this, it will require another mass-regeneration of the tests.

@RKSimon
Copy link
Collaborator

RKSimon commented Mar 21, 2019

Roman/Greg - is this still an issue?

@LebedevRI
Copy link
Member Author

Roman/Greg - is this still an issue?

Yep, still an issue.
You can see it by dropping some block of CHECK + CHECK-NEXT + CHECK-NEXT ... lines

@gregbedwell
Copy link
Collaborator

Right. So far I've held off going further with this because I'm scared how big the diff will be if I regenerate multiple lines over every single mca test... :-\

I guess I might just have to bite the bullet and just do it, as the issue is just going to get worse as more tests are committed.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla llvm-tools All llvm tools that do not have corresponding tag
Projects
None yet
Development

No branches or pull requests

3 participants