Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable and fix failing C11 <cfloat> and <float.h> tests #37920

Closed
ldionne opened this issue Aug 15, 2018 · 3 comments
Closed

Re-enable and fix failing C11 <cfloat> and <float.h> tests #37920

ldionne opened this issue Aug 15, 2018 · 3 comments
Assignees
@ldionne
Labels
bugzilla Issues migrated from bugzilla libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Comments

@ldionne
Copy link
Member

ldionne commented Aug 15, 2018

Bugzilla Link 38572
Resolution FIXED
Resolved on Jul 29, 2020 12:14
Version unspecified
OS All
CC @mclow
Fixed by commit(s) a5faf3c

Extended Description

I had to comment out tests for C11 features in the following files because they were failing:

std/depr/depr.c.headers/float_h.pass.cpp
std/language.support/support.limits/c.limits/cfloat.pass.cpp

They should be fixed and re-enabled.
@ldionne
Copy link
Member Author

ldionne commented Aug 15, 2018

assigned to @ldionne

@ldionne
Copy link
Member Author

ldionne commented Aug 15, 2018

The tests were commented out here: https://reviews.llvm.org/D50748

@ldionne
Copy link
Member Author

ldionne commented Jul 29, 2020

commit a5faf3c
Author: Louis Dionne ldionne@apple.com
Date: Wed Jul 29 14:24:02 2020 -0400

[libc++] Re-enable tests for C11 math macros in <float.h> and <cfloat>

Fixes llvm/llvm-project#37920 .

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldionne ldionne

Labels
bugzilla Issues migrated from bugzilla libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ldionne