Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ORCv1 "Legacy" classes #41331

Open
lhames opened this issue May 22, 2019 · 0 comments
Open

Deprecate ORCv1 "Legacy" classes #41331

lhames opened this issue May 22, 2019 · 0 comments
Labels
bugzilla Issues migrated from bugzilla orcjit

Comments

@lhames
Copy link
Contributor

lhames commented May 22, 2019

Bugzilla Link 41986
Version trunk
OS All
CC @AlexDenisov

Extended Description

Deprecation warnings need to be added to the legacy classes before 9.0 branches so that users of the stable branches (who may not read the release notes) find out about ORCv1's deprecation.

Ideally we would use the LLVM_ATTRIBUTE_DEPRECATED attribute (https://github.com/llvm-mirror/llvm/blob/master/include/llvm/Support/Compiler.h) for this, but I think it may only work for functions at the moment, not classes. If that's the case we should either develop a new attribute (LLVM_ATTRIBUTE_DEPRECATED_CLASS) or apply the deprecation warning to the class constructors.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla orcjit
Projects
None yet
Development

No branches or pull requests

1 participant