Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic_entry_values_x86_64 failing due to compiler changes #44119

Closed
vedantk opened this issue Feb 4, 2020 · 3 comments
Closed

basic_entry_values_x86_64 failing due to compiler changes #44119

vedantk opened this issue Feb 4, 2020 · 3 comments
Assignees
@labath
Labels
bugzilla Issues migrated from bugzilla lldb

Comments

@vedantk
Copy link
Collaborator

vedantk commented Feb 4, 2020

Bugzilla Link 44774
Resolution FIXED
Resolved on Jun 29, 2020 08:17
Version unspecified
OS All
Blocks #43461
CC @adrian-prantl,@dstenb,@JDevlieghere,@jmorse,@labath
Fixed by commit(s) a5c2317

Extended Description

The basic_entry_values_x86_64 test has started failing today due to an argument being optimized out:

--- FileCheck trace (code=1) ---
/Users/vsk/src/builds/llvm-ub-hardening-RA/bin/FileCheck /Users/vsk/src/llvm-ub-hardening/lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp -check-prefix=FUNC1-DESC

FileCheck input:
      Address: a.out[0x0000000100000d68] (a.out.__TEXT.__text + 24)
      Summary: a.out`func1(int&, int) + 24 at main.cpp:52:1
       Module: file = "/Users/vsk/src/builds/llvm-ub-hardening-RA/lldb-test-build.noindex/functionalities/param_entry_vals/basic_entry_values_x86_64/lldbsuite.test.lldbtest.test_dsym/a.out", arch = "x86_64"
  CompileUnit: id = {0x00000000}, file = "/Users/vsk/src/llvm-ub-hardening/lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp", language = "c++11"
     Function: id = {0x7fffffff0000002e}, name = "func1(int&, int)", mangled = "_Z5func1Rii", range = [0x0000000103f25d50-0x0000000103f25d6f)
     FuncType: id = {0x7fffffff0000002e}, byte-size = 0, decl = main.cpp:35, compiler_type = "void (int &, int)"
       Blocks: id = {0x7fffffff0000002e}, range = [0x103f25d50-0x103f25d6f)
    LineEntry: [0x0000000103f25d68-0x0000000103f25d6f): /Users/vsk/src/llvm-ub-hardening/lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp:52:1
       Symbol: id = {0x00000006}, range = [0x0000000103f25d50-0x0000000103f25d70), name="func1(int&, int)", mangled="_Z5func1Rii"



FileCheck output:

/Users/vsk/src/llvm-ub-hardening/lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp:51:17: error: FUNC1-DESC: expected string not found in input
 // FUNC1-DESC: name = "sink", type = "int &", location = DW_OP_entry_value(DW_OP_reg5 RDI)

Perhaps the test needs to be re-written to check in a fixed assembly file, so that DW_OP_entry_value evaluation can be tested in a way that's not dependent on the compiler.
@vedantk
Copy link
Collaborator Author

vedantk commented Feb 4, 2020

assigned to @labath

@llvmbot
Copy link
Collaborator

llvmbot commented Feb 5, 2020

Perhaps the test needs to be re-written to check in a fixed assembly file, so that DW_OP_entry_value evaluation can be tested in a way that's not dependent on the compiler.

It makes sense to me, since the entry values are "backup" locations depending on the code generated.

@labath
Copy link
Collaborator

labath commented Jun 29, 2020

Fixed by a5c2317.

@dstenb dstenb mannequin mentioned this issue Nov 22, 2019
Open
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@labath labath

Labels
bugzilla Issues migrated from bugzilla lldb
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vedantk @labath @llvmbot