-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffi/oprofile checked for even when explicitly disabled #5390
Comments
Also since Debian's libopagent.so doesn't link against bfd it fails to be found: configure:28860: gcc -o conftest -g -O2 conftest.c -lopagent -lpthread -lffi -ldl -lm -L/usr/lib/oprofile -Wl,-rpath,/usr/lib/oprofile
If I configure --with-oprofile I get an error that libopagent needs to be around. Here is relevant part from /usr/lib/oprofile/libopagent.la: Libraries that this one depends upon.dependency_libs=' -liberty -ldl' And dependencies: |
Possible fix for the oprofile part of this bug |
Fix for oprofile part, now checking bfd in the right order |
I've committed the OProfile part in r83503. Edwin, do you want to get the ffi part? |
anyone willing to finish this off? |
Patch to make --disable-libffi work and adjust the default |
Yeah, that's fine. Go ahead and commit. |
Fixed in r95712. I'm happy to change the defaults to pay attention to what's installed if Nick convinces people that's the right behavior. |
Extended Description
./configure --enable-ffi=no --enable-oprofile=no still checks for ffi and oprofile
and adds it to LIBS.
The problem is here in configure.ac:
dnl --enable-libffi : check whether the user wants to turn off libffi:
AC_ARG_ENABLE(libffi,AS_HELP_STRING(
--enable-libffi,[Check for the presence of libffi (default is YES)]),,
enableval=yes)
case "$enableval" in
yes) llvm_cv_enable_libffi="yes" ;;
no) llvm_cv_enable_libffi="no" ;;
*) AC_MSG_ERROR([Invalid setting for --enable-libffi. Use "yes" or "no"]) ;;
esac
enableval should be tested inside AC_ARG_ENABLE, otherwise it contains something else:
++ enable_ffi=no
...
The text was updated successfully, but these errors were encountered: