Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick 76fc35752d19ac605c1c1fd757af9c7c3bb4a906 to release/12.x #50102

Closed
ldionne opened this issue Jun 17, 2021 · 2 comments
Closed

Cherry-pick 76fc35752d19ac605c1c1fd757af9c7c3bb4a906 to release/12.x #50102

ldionne opened this issue Jun 17, 2021 · 2 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Comments

@ldionne
Copy link
Member

ldionne commented Jun 17, 2021

Bugzilla Link 50758
Resolution FIXED
Resolved on Jun 22, 2021 17:36
Version 12.0
OS All
Blocks #48661
CC @mclow,@tstellar
Fixed by commit(s) 76fc357 fa21c5d

Extended Description

That is:

[libc++] Make feature-test macros consistent with availability macros

Before this patch, feature-test macros didn't take special availability
markup into account, which means that feature-test macros can sometimes
appear to "lie". For example, if you compile in C++20 mode and target
macOS 10.13, the __cpp_lib_filesystem feature-test macro will be provided
even though the <filesystem> declarations are marked as unavailable.
This patch fixes that.

rdar://68142369

Differential Revision: https://reviews.llvm.org/D94983
@ldionne
Copy link
Member Author

ldionne commented Jun 17, 2021

assigned to @ldionne

@tstellar
Copy link
Collaborator

Merged: fa21c5d

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

No branches or pull requests

2 participants