-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libc++][PowerPC] midpoint.float.pass.cpp test failure for 13.0.0-rc1 on PowerPC #50772
Comments
Just to add to the original comment, here are the errors associated. libc++ :: std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp: /home/conanap/llvm/dev/llvm-project/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp:95:49: error: 'LONG_DOUBLE_IEEE128' is not defined, evaluates to 0 [-Werror,-Wundef] and libc++ :: libcxx/atomics/atomics.align/align.pass.cpp: command stderr:t.tmp.exe: /home/conanap/llvm/community/llvm-project/libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp:41: atomic_test::atomic_test() [T = LLIArr2]: Assertion `alignof(AtomicImpl) >= sizeof(AtomicImpl) && "expected natural alignment for lock-free type"' failed. error: command failed with exit status: 250 |
I created https://reviews.llvm.org/D108071. After approval I'll ask tstellar's permission to backport it to the release branch. I had a short look at the atomic issue, but don't have a solution. |
Albion, I've separated our the atomics align.pass.cpp into it's own bug, so we can focus this one on the midpoint.float.pass.cpp failure: llvm/llvm-bugzilla-archive#51548 |
Should we backport this patch instead? https://reviews.llvm.org/D108352 |
Hi Tom, that would be the patch we'd like to see backported, but we're just waiting on libc++ approval to commit |
to clarify, I'm talking about this patch: https://reviews.llvm.org/D108352 |
thanks for committing and cherry picking! |
Merged: 23ba373 |
mentioned in issue #51489 |
Extended Description
The following two tests fail on 13.0.0-rc1 for Ubuntu on PowerPC8 and PowerPC9:
Failed Tests (2):
libc++ :: libcxx/atomics/atomics.align/align.pass.cpp (PowerPC9 only)
libc++ :: std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp (PowerPC 8 and 9)
It is still being investigated.
The text was updated successfully, but these errors were encountered: