Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++][PowerPC] midpoint.float.pass.cpp test failure for 13.0.0-rc1 on PowerPC #50772

Closed
llvmbot opened this issue Aug 10, 2021 · 10 comments
Closed
Labels
bugzilla Issues migrated from bugzilla libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Comments

@llvmbot
Copy link
Member

llvmbot commented Aug 10, 2021

Bugzilla Link 51430
Resolution FIXED
Resolved on Oct 11, 2021 20:29
Version unspecified
OS Linux
Blocks #51489
Reporter LLVM Bugzilla Contributor
CC @amy-kwan,@mordante,@ldionne,@mclow,@tstellar
Fixed by commit(s) 4bef7a8 23ba373

Extended Description

The following two tests fail on 13.0.0-rc1 for Ubuntu on PowerPC8 and PowerPC9:
Failed Tests (2):
libc++ :: libcxx/atomics/atomics.align/align.pass.cpp (PowerPC9 only)
libc++ :: std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp (PowerPC 8 and 9)

It is still being investigated.

@llvmbot
Copy link
Member Author

llvmbot commented Aug 10, 2021

Just to add to the original comment, here are the errors associated.

libc++ :: std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp:

/home/conanap/llvm/dev/llvm-project/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp:95:49: error: 'LONG_DOUBLE_IEEE128' is not defined, evaluates to 0 [-Werror,-Wundef]
#if defined(PPC) && LONG_DOUBLE_128 && !LONG_DOUBLE_IEEE128

and libc++ :: libcxx/atomics/atomics.align/align.pass.cpp:

command stderr:

t.tmp.exe: /home/conanap/llvm/community/llvm-project/libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp:41: atomic_test::atomic_test() [T = LLIArr2]: Assertion `alignof(AtomicImpl) >= sizeof(AtomicImpl) && "expected natural alignment for lock-free type"' failed.

error: command failed with exit status: 250

@mordante
Copy link
Member

I created https://reviews.llvm.org/D108071.
Can you test whether this fixes the unit test error for midpoint?

After approval I'll ask tstellar's permission to backport it to the release branch.

I had a short look at the atomic issue, but don't have a solution.

@amy-kwan
Copy link
Contributor

Albion, I've separated our the atomics align.pass.cpp into it's own bug, so we can focus this one on the midpoint.float.pass.cpp failure: llvm/llvm-bugzilla-archive#51548

@tstellar
Copy link
Collaborator

Should we backport this patch instead? https://reviews.llvm.org/D108352

@llvmbot
Copy link
Member Author

llvmbot commented Aug 20, 2021

Hi Tom, that would be the patch we'd like to see backported, but we're just waiting on libc++ approval to commit

@llvmbot
Copy link
Member Author

llvmbot commented Aug 20, 2021

to clarify, I'm talking about this patch: https://reviews.llvm.org/D108352

@ldionne
Copy link
Member

ldionne commented Aug 20, 2021

Thanks for the patch! I committed the fix to main as 4bef7a8 and cherry-picked it to release/13.x as 23ba373.

@llvmbot
Copy link
Member Author

llvmbot commented Aug 20, 2021

thanks for committing and cherry picking!

@tstellar
Copy link
Collaborator

Merged: 23ba373

@tstellar
Copy link
Collaborator

mentioned in issue #51489

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

No branches or pull requests

5 participants