Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed ExecutionEngine/JITLink/X86/MachO_x86-64_self_relocation_exec.test test in 15.0.0-rc1 on macOS. #56817

Closed
tru opened this issue Jul 30, 2022 · 10 comments · Fixed by llvm/llvm-project-release-prs#59

Comments

@tru
Copy link
Collaborator

tru commented Jul 30, 2022

This test fail on macOS with 15.0.0-rc1 and it is a regression from 14.x.

Can someone have a look and let us know if it's blocker for 15.x or not.

@tru tru added the jitlink label Jul 30, 2022
@tru tru added this to the LLVM 15.0.0 Release milestone Jul 30, 2022
@llvmbot
Copy link
Collaborator

llvmbot commented Jul 30, 2022

@llvm/issue-subscribers-jitlink

@lhames
Copy link
Contributor

lhames commented Jul 30, 2022

@tru — can you share any error messages from the failure?

I’ll be back on Tuesday (PDT) and can take a look then. I don’t think this should be considered a blocker though — it’s fine to just disable the test on the release branch.

@sunho
Copy link
Member

sunho commented Jul 30, 2022

The test actually passes on my local intel macOS machine. Could you share more details about your environment and setup?

@tru
Copy link
Collaborator Author

tru commented Aug 1, 2022

Ok this was confusing - because it worked for me as well if I just built llvm normally - but within the test-release script we use to do testing and release binaries it was failing. I managed to replicate it and get the actual error message:

FAIL: LLVM :: ExecutionEngine/JITLink/X86/MachO_x86-64_self_relocation_exec.test (33 of 70)
******************** TEST 'LLVM :: ExecutionEngine/JITLink/X86/MachO_x86-64_self_relocation_exec.test' FAILED ********************
Script:
--
: 'RUN: at line 1';   /Users/tobias/code/github-runner/_work/llvm-release-build/llvm-release-build/build/15.0.0-rc1/rc1/Phase3/Release/llvmCore-15.0.0-rc1.obj/bin/llvm-mc -triple=x86_64-apple-macosx10.9 -filetype=obj -o /Users/tobias/code/github-runner/_work/llvm-release-build/llvm-release-build/build/15.0.0-rc1/rc1/Phase3/Release/llvmCore-15.0.0-rc1.obj/test/ExecutionEngine/JITLink/X86/Output/MachO_x86-64_self_relocation_exec.test.tmp /Users/tobias/code/github-runner/_work/llvm-release-build/llvm-release-build/build/15.0.0-rc1/rc1/llvm-project/llvm/test/ExecutionEngine/JITLink/X86/Inputs/x86-64_self_relocation.s
: 'RUN: at line 2';   /Users/tobias/code/github-runner/_work/llvm-release-build/llvm-release-build/build/15.0.0-rc1/rc1/Phase3/Release/llvmCore-15.0.0-rc1.obj/bin/llvm-jitlink -show-graph /Users/tobias/code/github-runner/_work/llvm-release-build/llvm-release-build/build/15.0.0-rc1/rc1/Phase3/Release/llvmCore-15.0.0-rc1.obj/test/ExecutionEngine/JITLink/X86/Output/MachO_x86-64_self_relocation_exec.test.tmp
: 'RUN: at line 3';   /Users/tobias/code/github-runner/_work/llvm-release-build/llvm-release-build/build/15.0.0-rc1/rc1/Phase3/Release/llvmCore-15.0.0-rc1.obj/bin/llvm-jitlink -show-graph -add-self-relocations /Users/tobias/code/github-runner/_work/llvm-release-build/llvm-release-build/build/15.0.0-rc1/rc1/Phase3/Release/llvmCore-15.0.0-rc1.obj/test/ExecutionEngine/JITLink/X86/Output/MachO_x86-64_self_relocation_exec.test.tmp
--
Exit Code: 1

Command Output (stderr):
--
/Users/tobias/code/github-runner/_work/llvm-release-build/llvm-release-build/build/15.0.0-rc1/rc1/Phase3/Release/llvmCore-15.0.0-rc1.obj/bin/llvm-jitlink: Symbols not found: [ _llvm_orc_registerJITLoaderGDBAllocAction ]

--

********************

So this happens in the 3rd phase of the testing script, phase3 is configured like this:

env CC=/Users/tobias/code/github-runner/_work/llvm-release-build/llvm-release-build/build/15.0.0-rc1/rc1/Phase2/Release/llvmCore-15.0.0-rc1.install/usr/local/bin/clang CXX=/Users/tobias/code/github-runner/_work/llvm-release-build/llvm-release-build/build/15.0.0-rc1/rc1/Phase2/Release/llvmCore-15.0.0-rc1.install/usr/local/bin/clang++ cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=OFF -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DLLVM_ENABLE_PROJECTS=llvm;clang;clang-tools-extra;openmp;lld;polly;mlir;flang -DLLVM_LIT_ARGS=-j 12 -DLLVM_ENABLE_RUNTIMES=;compiler-rt;libcxx;libcxxabi;libunwind -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache /Users/tobias/code/github-runner/_work/llvm-release-build/llvm-release-build/build/15.0.0-rc1/rc1/llvm-project/llvm

Does that give the information needed?

@lhames
Copy link
Contributor

lhames commented Aug 3, 2022

@tru Yep -- that's what I needed. Thanks. I'll try to figure out a fix.

@lhames
Copy link
Contributor

lhames commented Aug 4, 2022

@tru I've committed b5f76d8 to the mainline, which I think should fix this. Are you managing cherry-picks to the release branch? (If not I can find out who is and try to get this in)

@sunho
Copy link
Member

sunho commented Aug 4, 2022

We've got a github bot for cherry-picking.

@sunho
Copy link
Member

sunho commented Aug 4, 2022

/cherry-pick b5f76d8

@llvmbot
Copy link
Collaborator

llvmbot commented Aug 4, 2022

/branch llvm/llvm-project-release-prs/issue56817

@llvmbot
Copy link
Collaborator

llvmbot commented Aug 4, 2022

/pull-request llvm/llvm-project-release-prs#59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants