Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libcxx] Thread-safety analysis: shared_timed_mutex is not annotated #57035

Closed
jcelerier opened this issue Aug 9, 2022 · 3 comments
Closed

[libcxx] Thread-safety analysis: shared_timed_mutex is not annotated #57035

jcelerier opened this issue Aug 9, 2022 · 3 comments
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Comments

@jcelerier
Copy link

It would be good to be able to assert the threading semantics with it, too
@EugeneZelenko EugeneZelenko added libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. and removed new issue labels Aug 9, 2022
@aaronpuchert
Copy link
Member

Annotations have been added to __shared_mutex_base in https://reviews.llvm.org/D54290, but not shared_mutex and shared_timed_mutex. Should be easy to fix though.

@aaronpuchert
Copy link
Member

Proposed fix: https://reviews.llvm.org/D154354.

@ldionne
Copy link
Member

ldionne commented Jul 6, 2023

Fixed by 5b666cf.

@ldionne ldionne closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ldionne @aaronpuchert @jcelerier @EugeneZelenko