Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang -fcolor-diagnostics and !isatty(stderr) #8522

Closed
llvmbot opened this issue Sep 15, 2010 · 3 comments
Closed

clang -fcolor-diagnostics and !isatty(stderr) #8522

llvmbot opened this issue Sep 15, 2010 · 3 comments
Assignees
@akyrtzi
Labels
bugzilla Issues migrated from bugzilla clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Sep 15, 2010

Bugzilla Link 8150
Resolution FIXED
Resolved on Sep 23, 2010 07:56
Version trunk
OS All
Attachments Proposed patch
Reporter LLVM Bugzilla Contributor
CC @akyrtzi,@tkremenek

Extended Description

Clang's -fcolor-diagnostics command-line option doesn't enable colored diagnostics if it's of the opinion that stderr can't handle them (i.e. StandardErrHasColors() returns false).
IMHO, if this option is explicitly passed to the driver then it should respect that. (For instance, ccache users can't get colored diagnostics otherwise because ccache also caches warnings, so it has to redirect stderr)

I'm attaching a small patch that fixes this.
@llvmbot
Copy link
Collaborator Author

llvmbot commented Sep 15, 2010

assigned to @akyrtzi

@tkremenek
Copy link
Contributor

Argiris: When you get a chance, can you review this patch?

@akyrtzi
Copy link
Contributor

akyrtzi commented Sep 23, 2010

Makes sense, applied at r114638; thanks!

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
cyndyishida pushed a commit to cyndyishida/llvm-project that referenced this issue Apr 9, 2024
@adrian-prantl
Merge pull request llvm#8522 from apple/dl/swift/release/6.0/clang-Mo…
06b2847 
…ve-CCC_OVERRIDE_OPTIONS-implementation-to-Driver-85425

[clang] Move CCC_OVERRIDE_OPTIONS implementation to Driver
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akyrtzi akyrtzi

Labels
bugzilla Issues migrated from bugzilla clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akyrtzi @tkremenek @llvmbot