Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROJ_SRC_DIR != PROJ_OBJ_DIR in srcdir=objdir build due to symlinks #1220

Closed
lattner opened this issue Jul 26, 2006 · 3 comments
Closed

PROJ_SRC_DIR != PROJ_OBJ_DIR in srcdir=objdir build due to symlinks #1220

lattner opened this issue Jul 26, 2006 · 3 comments
Labels
bugzilla Issues migrated from bugzilla build-problem

Comments

@lattner
Copy link
Collaborator

lattner commented Jul 26, 2006

Bugzilla Link 848
Resolution FIXED
Resolved on Mar 06, 2010 14:00
Version 1.7
OS All

Extended Description

I have the following source layout:

~/cvs/llvm is my llvm tree
~/llvm is a symlink to ~/cvs/llvm

Because PROJ_OBJ_DIR and PROJ_OBJ_ROOT are defined as:

PROJ_OBJ_DIR := $(shell pwd)
PROJ_OBJ_ROOT := $(subst //,/,$(shell cd $(PROJ_OBJ_DIR)/$(LEVEL); pwd))

They fully resolve the symlink to ~/cvs/llvm, but PROJ_SRC_ROOT is the un-fully-resolved path ~/llvm.
This breaks stuff that checks to see if SRCDIR==OBJDIR, such as 'make dist' and other stuff:

If the Makefile in the source tree has been updated, copy it over into the

build tree.

We MUST build distribution with OBJ_DIR != SRC_DIR

-Chris
@llvmbot
Copy link
Collaborator

llvmbot commented Jul 28, 2006

Mine.

@llvmbot
Copy link
Collaborator

llvmbot commented Jul 28, 2006

Chris:

I have a patch for this, but not sure how to test it.
I've recreate the symlink situation and everything builds fine in it.
To test, is it sufficient to touch lib/System/Makefile and see if the "Updating
Makefile" message appears? If it doesn't, are we good to go on this?

@llvmbot
Copy link
Collaborator

llvmbot commented Jul 28, 2006

Using /bin/pwd seems to do the trick. Patches here:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060724/036308.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060724/036309.html

Resolved.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla build-problem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lattner @llvmbot