-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asmparser doesn't report errors it finds #1258
Comments
Reid, please look into this. This is a really annoying regression from your "remove EH" patch. You'll notice that running on this .ll file causes the parser to call GenerateError. However, it doesn't print -Chris |
I ran the test case. The error is produced in this production: Module : FunctionList { When ModuleDone() is finished, the TriggerError flag is true and CHECK_FOR_ERROR yyparse(); This doesn't check for the non-zero result from yyparse because it expects // Check to make sure the parser succeeded // Check to make sure that parsing produced a result Which checks both error conditions and returns 0 on them both. This fixes the |
Nice. Does it also print out the error message with that patch? |
Yes, the error message is printed correctly. It never hits the validator. |
perfect |
Resolved, patch here: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20061009/038418.html |
mentioned in issue llvm/llvm-bugzilla-archive#895 |
1 similar comment
mentioned in issue llvm/llvm-bugzilla-archive#895 |
Extended Description
This .ll file is buggy (%X isn't defined):
ulong %foo(ulong %x) {
%tmp.1 = load long* %X ; [#uses=1]
%tmp.3 = cast long %tmp.1 to ubyte ; [#uses=1]
%tmp.4 = shl ulong %x, ubyte %tmp.3 ; [#uses=1]
ret ulong %tmp.4
}
When parsing it, I don't get a good error from the asmparser, I get assertion failures.
I could have sworn this used to be caught.
-Chris
The text was updated successfully, but these errors were encountered: