Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make bugpoint-gccas" spews binary garbage in Burg #1263

Closed
nlewycky opened this issue Aug 30, 2006 · 2 comments
Closed

"make bugpoint-gccas" spews binary garbage in Burg #1263

nlewycky opened this issue Aug 30, 2006 · 2 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla test-suite

Comments

@nlewycky
Copy link
Contributor

Bugzilla Link 891
Resolution FIXED
Resolved on Feb 22, 2010 12:44
Version trunk
OS Linux
Attachments output from "make bugpoint-gccas > garbage.txt"

Extended Description

In llvm-test/MultiSource/Applications/Burg, running "make bugpoint-gccas" or
bugpoint-gccld will emit raw llvm bytecode to standard out. This is thoroughly
unpleasant.

@nlewycky
Copy link
Contributor Author

assigned to @lattner

@lattner
Copy link
Collaborator

lattner commented Sep 2, 2006

Oops, didn't notice this bug. Yes you're right, that really is impolite! :)

Fix here:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060828/037386.html

-Chris

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
jeanPerier pushed a commit to jeanPerier/llvm-project that referenced this issue Jan 4, 2022
* [MLIR] Attribute and type formats in ODS

Declarative attribute and type formats with assembly formats. Define an
`assemblyFormat` field in attribute and type defs with a `mnemonic` to
generate a parser and printer.

```tablegen
def MyAttr : AttrDef<MyDialect, "MyAttr"> {
  let parameters = (ins "int64_t":$count, "AffineMap":$map);
  let mnemonic = "my_attr";
  let assemblyFormat = "`<` $count `,` $map `>`";
}
```

Use `struct` to define a comma-separated list of key-value pairs:

```tablegen
def MyType : TypeDef<MyDialect, "MyType"> {
  let parameters = (ins "int":$one, "int":$two, "int":$three);
  let mnemonic = "my_attr";
  let assemblyFormat = "`<` $three `:` struct($one, $two) `>`";
}
```

Use `struct(*)` to capture all parameters.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D111594

* [mlir][ods] AttrOrTypeDef format: parse types

Add template specialization to `FieldParser` for parsing types.

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D113867

* [Flang] Sync after upstreaming FIR LLVMPointer Type

Changes include the following,
-> Use of assembly format for printer and parser
-> The assembly format worked better with the default Type::get
function with the context. Hence using that and removing the custom
builder. Updating usage.
-> Tests for the type and conversion to llvm

Reviewed By: clementval

Differential Revision: https://reviews.llvm.org/D113755

Co-authored-by: Jeff Niu <jeffniu@google.com>
Co-authored-by: Mogball <jeffniu22@gmail.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla test-suite
Projects
None yet
Development

No branches or pull requests

2 participants