Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-ld infinite loop on bc archive #1370

Closed
llvmbot opened this issue Nov 10, 2006 · 5 comments
Closed

llvm-ld infinite loop on bc archive #1370

llvmbot opened this issue Nov 10, 2006 · 5 comments
Labels
bugzilla Issues migrated from bugzilla llvm-tools All llvm tools that do not have corresponding tag quality-of-implementation

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Nov 10, 2006

Bugzilla Link 998
Resolution FIXED
Resolved on Feb 22, 2010 12:42
Version 1.4
OS All
Attachments llvm-ld infinite bc archive loop and native code gen fix.
Reporter LLVM Bugzilla Contributor

Extended Description

llvm-ld can (and did) go into an infinite loop while processing a bytecode
archive. Cleaned up the loop in LinkArchive.cpp -- it shouldn't be an infinite
loop. The code should have implemented a loop that keeps processing this
archive until the set of undefined symbols doesn't change.

Also, bytecode archives improperly get fed to the native linker. At least Linux
bitches about malformed archives when this happens, YMMV.
@llvmbot
Copy link
Collaborator Author

llvmbot commented Nov 10, 2006

Reid is reviewing this patch.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Nov 11, 2006

updated patch with fewer calories

@llvmbot
Copy link
Collaborator Author

llvmbot commented Nov 11, 2006

A couple of more suggested refinements...

@llvmbot
Copy link
Collaborator Author

llvmbot commented Nov 11, 2006

fix typo...

@llvmbot
Copy link
Collaborator Author

llvmbot commented Nov 11, 2006

Scott's first patch passed muster and fixes the issue. Patches here:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20061106/039823.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20061106/039824.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20061106/039821.html
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20061106/039822.html

Thanks, Scott!

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla llvm-tools All llvm tools that do not have corresponding tag quality-of-implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@llvmbot