Bug 5735 – JIT should not codegen available_externally functions.

Bug 5735 - JIT should not codegen available_externally functions.

Summary:

JIT should not codegen available_externally functions.

Status:	RESOLVED FIXED

Product:	libraries
Classification:	Unclassified
Component:	Target-Independent JIT
Version:	trunk
Platform:	PC All

Importance:	P normal
Assigned To:	Jeffrey Yasskin

URL:
Keywords:

Depends on:	5737
Blocks:
	Show dependency tree / graph

Reported:	2009-12-09 13:22 CST by Jeffrey Yasskin
Modified:	2010-01-27 15:50 CST (History)
CC List:	3 users (show)

See Also:

Attachments
Failing test + assertion (2.13 KB, patch) 2009-12-09 13:22 CST, Jeffrey Yasskin	Details \| Diff
Proposed fix (8.04 KB, patch) 2009-12-14 19:22 CST, Jeffrey Yasskin	Details \| Diff
Test for ghost available_externally functions (1.88 KB, patch) 2009-12-22 18:26 CST, Jeffrey Yasskin	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jeffrey Yasskin 2009-12-09 13:22:54 CST

Created attachment 3931 [details]
Failing test + assertion

The attached patch currently fails because the JIT tries to compile the
available_externally function instead of dlsym'ing the existing definition.

Comment 1 Jeffrey Yasskin 2009-12-14 19:22:44 CST

Created attachment 3948 [details]
Proposed fix

Comment 2 Jeffrey Yasskin 2009-12-17 15:48:28 CST

Fixed by r91626.

Comment 3 Jeffrey Yasskin 2009-12-22 18:25:19 CST

I reverted part of this fix in r91943 because it broke VMKit. Lazy-loaded
available_externally functions are broken again.

Comment 4 Jeffrey Yasskin 2009-12-22 18:26:07 CST

Created attachment 3971 [details]
Test for ghost available_externally functions

Comment 5 Jeffrey Yasskin 2010-01-27 15:50:41 CST

Fixed in r94686.