Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

162099 breaks nss #14460

Closed
llvmbot opened this issue Oct 15, 2012 · 5 comments
Closed

162099 breaks nss #14460

llvmbot opened this issue Oct 15, 2012 · 5 comments
Labels
bugzilla Issues migrated from bugzilla llvm:codegen

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Oct 15, 2012

Bugzilla Link 14088
Resolution FIXED
Resolved on Oct 15, 2012 13:22
Version trunk
OS Linux
Attachments testcase
Reporter LLVM Bugzilla Contributor
CC @stoklund

Extended Description

r162099 causes some test failures in nss. I have reduced it to the attached testcase.
@stoklund
Copy link
Mannequin

stoklund mannequin commented Oct 15, 2012

Works for me. Please provide a more detailed description of the problem.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Oct 15, 2012

assembly output with 162099

@llvmbot
Copy link
Collaborator Author

llvmbot commented Oct 15, 2012

assembly output with 162098

@llvmbot
Copy link
Collaborator Author

llvmbot commented Oct 15, 2012

The diff of the produced assembly is:

--- test-good.s 2012-10-15 13:01:37.102036453 -0400
+++ test-bad.s 2012-10-15 13:01:37.093036444 -0400
@@ -47,7 +47,7 @@
imull $100, %esi, %edx
subl %edx, %ecx
movswl %cx, %ecx

  • movw %cx, 16(%rsp)
  • movw %ax, 16(%rsp)
    movslq %ecx, %rcx
    imulq $1717986919, %rcx, %rcx ## imm = 0x66666667
    sarq $34, %rcx

Not haw we are now storing an invalid value is 16(%rsp).

@llvmbot
Copy link
Collaborator Author

llvmbot commented Oct 15, 2012

Fixed in r165951.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 3, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla llvm:codegen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@llvmbot