Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSABI Record Layout is broken with external sources #22174

Closed
llvmbot opened this issue Dec 10, 2014 · 2 comments
Closed

MSABI Record Layout is broken with external sources #22174

llvmbot opened this issue Dec 10, 2014 · 2 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla clang:codegen

Comments

@llvmbot
Copy link
Collaborator

llvmbot commented Dec 10, 2014

Bugzilla Link 21800
Resolution FIXED
Resolved on Aug 14, 2015 12:03
Version unspecified
OS Windows NT
Reporter LLVM Bugzilla Contributor

Extended Description

To reproduce this, one can run the following LLDB test:

D:\python_src\Python-2.7.8\PCbuild\python_d.exe D:\src\llvm\tools\lldb\test/dotest.py -q --arch=i686 --executable D:/src/llvm/build/ninja/bin/lldb.exe -s D:/src/llvm/build/ninja/lldb-test-traces -u CXXFLAGS -u CFLAGS -C D:\src\llvm\build\ninja\bin\clang.exe -p TestDataFormatterLibcxxVBool.py D:\src\llvm\tools\lldb\test\functionalities\data-formatter\data-formatter-stl\libcxx\vbool

You will get the following assertion failure:

Assertion failed: Allowed && "Externally-placed field cannot be placed here", file ....\tools\clang\lib\AST\RecordLayoutBuilder.cpp, line 1738

This is happening because in RecordLayoutBuilder.cpp, the following check in ASTContext::getASTRecordLayout():

if (isMsLayout(D) && !D->getASTContext().getExternalSource()) {
NewEntry = BuildMicrosoftASTRecordLayout(D);
}

is failing since getExternalSource() is returning true, so it is trying to use non-MSABI record layout.

Data formatter tests need to be disabled on Windows until this is fixed, so please re-enable them, or file a bug to re-enable them, once this is fixed.

@llvmbot
Copy link
Collaborator Author

llvmbot commented Dec 10, 2014

assigned to @majnemer

@llvmbot
Copy link
Collaborator Author

llvmbot commented Aug 14, 2015

This was fixed a long time ago.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 9, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla clang:codegen
Projects
None yet
Development

No branches or pull requests

1 participant