Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lld does not implement --dynamic-list (used by sanitizers) #27067

Closed
emaste opened this issue Feb 22, 2016 · 6 comments
Closed

lld does not implement --dynamic-list (used by sanitizers) #27067

emaste opened this issue Feb 22, 2016 · 6 comments
Labels
bugzilla Issues migrated from bugzilla lld

Comments

@emaste
Copy link
Member

emaste commented Feb 22, 2016

Bugzilla Link 26693
Resolution FIXED
Resolved on Apr 18, 2016 13:37
Version unspecified
OS FreeBSD
Blocks #23588
CC @rui314

Extended Description

In clang/lib/Driver/Tools.cpp addSanitizerDynamicList(), clang uses the --dynamic-list option, and my so check-asan in my self-hosted llvm/clang/lld test fails.

FAILED: cd /tank/emaste/src/llvm/build-nodebug/projects/compiler-rt/lib/asan/tests && /tank/emaste/src/llvm/build-nodebug/./bin/clang ASAN_INST_TEST_OBJECTS.gtest-all.cc.x86_64-inline.o ASAN_INST_TEST_OBJECTS.asan_asm_test.cc.x86_64-inline.o ASAN_INST_TEST_OBJECTS.asan_globals_test.cc.x86_64-inline.o ASAN_INST_TEST_OBJECTS.asan_interface_test.cc.x86_64-inline.o ASAN_INST_TEST_OBJECTS.asan_test.cc.x86_64-inline.o ASAN_INST_TEST_OBJECTS.asan_oob_test.cc.x86_64-inline.o ASAN_INST_TEST_OBJECTS.asan_mem_test.cc.x86_64-inline.o ASAN_INST_TEST_OBJECTS.asan_str_test.cc.x86_64-inline.o ASAN_INST_TEST_OBJECTS.asan_test_main.cc.x86_64-inline.o -o /tank/emaste/src/llvm/build-nodebug/projects/compiler-rt/lib/asan/tests/default/Asan-x86_64-inline-Test -Wl,-z,origin -Wl,-allow-shlib-undefined --driver-mode=g++ -fsanitize=address -m64
warning: unknown argument: --dynamic-list=/tank/emaste/src/llvm/build-nodebug/bin/../lib/clang/3.9.0/lib/freebsd/libclang_rt.asan-x86_64.a.syms

From the ld man page --dynamic-list is documented as:

   --dynamic-list=dynamic-list-file
       Specify the name of a dynamic list file to the linker.  This is
       typically used when creating shared libraries to specify a list of
       global symbols whose references shouldn't be bound to the
       definition within the shared library, or creating dynamically
       linked executables to specify a list of symbols which should be
       added to the symbol table in the executable.  This option is only
       meaningful on ELF platforms which support shared libraries.
@emaste
Copy link
Member Author

emaste commented Apr 13, 2016

r266227

@llvmbot
Copy link
Collaborator

llvmbot commented Apr 18, 2016

r266227

So, can this be closed ?

@rui314
Copy link
Member

rui314 commented Apr 18, 2016

Ed, can you test it again?

@emaste
Copy link
Member Author

emaste commented Apr 18, 2016

Ed, can you test it again?

Yes, 'ninja check-asan' builds and all expected tests pass.

@rui314
Copy link
Member

rui314 commented Apr 18, 2016

Cool. Let's call it done. If the existing feature is not enough, please open a new bug.

@emaste
Copy link
Member Author

emaste commented Apr 18, 2016

Cool. Let's call it done. If the existing feature is not enough, please open
a new bug.

Agreed -- I closed this PR earlier today.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla lld
Projects
None yet
Development

No branches or pull requests

3 participants