Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only one of multiple mangled symbols matching a version script entry has the symbol version appended #29660

Closed
emaste opened this issue Sep 7, 2016 · 5 comments
Closed

Only one of multiple mangled symbols matching a version script entry has the symbol version appended #29660

emaste opened this issue Sep 7, 2016 · 5 comments
Labels
bugzilla Issues migrated from bugzilla lld:ELF

Comments

@emaste
Copy link
Member

emaste commented Sep 7, 2016

Bugzilla Link 30312
Resolution FIXED
Resolved on Nov 07, 2016 14:03
Version unspecified
OS FreeBSD
Blocks #23588

Extended Description

I've added a change to a test case to demonstrate the issue in https://reviews.llvm.org/D24306

Both of these symbols demangle to abc::abc():
_ZN3abcC1Ev
_ZN3abcC2Ev

(These would be abc's complete object constructor and base object constructor, respectively.)

however with "abc::abc()" in the version script only one of the two receives the symbol version.

From llvm-readobj -V -dyn-symbols I find these two symbols:

_ZN3abcC1Ev@
_ZN3abcC2Ev@@LIBSAMPLE_1.0
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 8, 2016

Patch: https://reviews.llvm.org/D24336

@llvmbot
Copy link
Collaborator

llvmbot commented Sep 13, 2016

r281318

@emaste
Copy link
Member Author

emaste commented Sep 14, 2016

Reopened as this change was reverted in r281411 due to buildbot failures.

FWIW it passes on my FreeBSD 10.3 machine.

@emaste
Copy link
Member Author

emaste commented Sep 15, 2016

Recommitted as r281605

@llvmbot
Copy link
Collaborator

llvmbot commented Sep 15, 2016

Yes, but still waiting for build bot, so a bit too early, lets hope it is fine )

(http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu)

@emaste emaste mentioned this issue Apr 13, 2015
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla lld:ELF
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emaste @llvmbot