-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn on pointless qualifiers with fixit to remove them #9430
Comments
Part of this is already -Wignored-qualifiers. We should finish off the cases it doesn't catch and add fixits. In this testcase: static const const int test1 = 10; Wignored-qualifiers only complains about the return on test2, and without a fixit. |
The return type cases I believe are fixed in r126321, thanks to Hans. |
Retargeting as a clang-tidy check. This does make sense in a definition, so it's only a style choice whether to keep the |
@llvm/issue-subscribers-clang-tidy |
This is now fixed, via
|
Extended Description
We'd like a warning on the qualifier in code like:
with fixit to remove the dead qualifier. The one use case we want to not break is:
I'm proposing the warning name -Wpointless-qualifier.
The text was updated successfully, but these errors were encountered: