11 #include "clang/AST/ASTContext.h"
12 #include "clang/ASTMatchers/ASTMatchFinder.h"
13 #include "clang/Lex/Lexer.h"
15 using namespace clang::ast_matchers;
19 namespace readability {
21 void UniqueptrDeleteReleaseCheck::registerMatchers(MatchFinder *
Finder) {
22 auto IsSusbstituted = qualType(anyOf(
23 substTemplateTypeParmType(), hasDescendant(substTemplateTypeParmType())));
25 auto UniquePtrWithDefaultDelete = classTemplateSpecializationDecl(
26 hasName(
"std::unique_ptr"),
27 hasTemplateArgument(1, refersToType(qualType(hasDeclaration(cxxRecordDecl(
28 hasName(
"std::default_delete")))))));
31 cxxDeleteExpr(has(ignoringParenImpCasts(cxxMemberCallExpr(
32 on(expr(hasType(UniquePtrWithDefaultDelete),
33 unless(hasType(IsSusbstituted)))
35 callee(cxxMethodDecl(hasName(
"release")))))))
40 void UniqueptrDeleteReleaseCheck::check(
41 const MatchFinder::MatchResult &
Result) {
42 const auto *PtrExpr = Result.Nodes.getNodeAs<Expr>(
"uptr");
43 const auto *DeleteExpr = Result.Nodes.getNodeAs<Expr>(
"delete");
45 if (PtrExpr->getLocStart().isMacroID())
51 if (PtrExpr->getType()->isDependentType())
54 SourceLocation AfterPtr =
55 Lexer::getLocForEndOfToken(PtrExpr->getLocEnd(), 0, *Result.SourceManager,
56 Result.Context->getLangOpts());
58 diag(DeleteExpr->getLocStart(),
59 "prefer '= nullptr' to 'delete x.release()' to reset unique_ptr<> "
61 << FixItHint::CreateRemoval(CharSourceRange::getCharRange(
62 DeleteExpr->getLocStart(), PtrExpr->getLocStart()))
63 << FixItHint::CreateReplacement(
64 CharSourceRange::getTokenRange(AfterPtr, DeleteExpr->getLocEnd()),
std::unique_ptr< ast_matchers::MatchFinder > Finder