11 #include "llvm/ADT/Optional.h"
12 #include "clang/ASTMatchers/ASTMatchFinder.h"
13 #include "clang/ASTMatchers/ASTMatchers.h"
14 #include "clang/Lex/Lexer.h"
16 using namespace clang::ast_matchers;
20 namespace readability {
23 SourceRange getTypeRange(
const ParmVarDecl &Param) {
24 if (Param.getIdentifier() !=
nullptr)
25 return SourceRange(Param.getLocStart(),
26 Param.getLocEnd().getLocWithOffset(-1));
27 return Param.getSourceRange();
32 void AvoidConstParamsInDecls::registerMatchers(MatchFinder *
Finder) {
33 const auto ConstParamDecl =
34 parmVarDecl(hasType(qualType(isConstQualified()))).bind(
"param");
36 functionDecl(unless(isDefinition()),
39 unless(cxxMethodDecl(ofClass(cxxRecordDecl(isLambda())))),
40 has(typeLoc(forEach(ConstParamDecl))))
47 const MatchFinder::MatchResult &
Result) {
48 const SourceManager &Sources = *Result.SourceManager;
49 std::pair<FileID, unsigned> LocInfo =
50 Sources.getDecomposedLoc(Range.getBegin());
51 StringRef
File = Sources.getBufferData(LocInfo.first);
52 const char *TokenBegin = File.data() + LocInfo.second;
53 Lexer RawLexer(Sources.getLocForStartOfFile(LocInfo.first),
54 Result.Context->getLangOpts(), File.begin(), TokenBegin,
58 while (!RawLexer.LexFromRawLexer(Tok)) {
59 if (Sources.isBeforeInTranslationUnit(Range.getEnd(), Tok.getLocation()))
61 if (Tok.is(tok::raw_identifier)) {
62 IdentifierInfo &Info = Result.Context->Idents.get(StringRef(
63 Sources.getCharacterData(Tok.getLocation()), Tok.getLength()));
64 Tok.setIdentifierInfo(&Info);
65 Tok.setKind(Info.getTokenID());
67 if (Tok.is(tok::kw_const))
73 void AvoidConstParamsInDecls::check(
const MatchFinder::MatchResult &
Result) {
74 const auto *Func = Result.Nodes.getNodeAs<FunctionDecl>(
"func");
75 const auto *Param = Result.Nodes.getNodeAs<ParmVarDecl>(
"param");
77 if (!Param->getType().isLocalConstQualified())
80 auto Diag = diag(Param->getLocStart(),
81 "parameter %0 is const-qualified in the function "
82 "declaration; const-qualification of parameters only has an "
83 "effect in function definitions");
84 if (Param->getName().empty()) {
85 for (
unsigned int i = 0; i < Func->getNumParams(); ++i) {
86 if (Param == Func->getParamDecl(i)) {
95 if (Param->getLocStart().isMacroID() != Param->getLocEnd().isMacroID()) {
101 CharSourceRange FileRange = Lexer::makeFileCharRange(
102 CharSourceRange::getTokenRange(getTypeRange(*Param)),
103 *Result.SourceManager, Result.Context->getLangOpts());
105 if (!FileRange.isValid())
108 auto Tok =
ConstTok(FileRange, Result);
111 Diag << FixItHint::CreateRemoval(
112 CharSourceRange::getTokenRange(Tok->getLocation(), Tok->getLocation()));
std::unique_ptr< ast_matchers::MatchFinder > Finder
static llvm::Optional< Token > ConstTok(CharSourceRange Range, const MatchFinder::MatchResult &Result)
CharSourceRange Range
SourceRange for the file name.